Small defensive tweak on checking expression

This commit is contained in:
Phil Nash 2011-03-01 09:55:17 +00:00
parent e401601ac1
commit 01234172a9

View File

@ -44,7 +44,7 @@ namespace Catch
m_filename( filename ), m_filename( filename ),
m_line( line ), m_line( line ),
m_expr( expr ), m_expr( expr ),
m_op( m_expr[0] == '!' ? "!" : "" ), m_op( isNotExpression( expr ) ? "!" : "" ),
m_result( result ), m_result( result ),
m_isNot( isNot ), m_isNot( isNot ),
m_expressionIncomplete( false ) m_expressionIncomplete( false )
@ -152,6 +152,15 @@ namespace Catch
else else
return "{can't expand - use " + m_macroName + "_NOT( " + m_expr.substr(1) + " ) instead of " + m_macroName + "( " + m_expr + " ) for better diagnostics}"; return "{can't expand - use " + m_macroName + "_NOT( " + m_expr.substr(1) + " ) instead of " + m_macroName + "( " + m_expr + " ) for better diagnostics}";
} }
///////////////////////////////////////////////////////////////////////////
bool isNotExpression
(
const char* expr
)
{
return expr && expr[0] == '!';
}
protected: protected:
std::string m_macroName; std::string m_macroName;