3rd-party
/
catch2
mirror of https://github.com/catchorg/Catch2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix & extend tests for comparing const instances of zero lit types

This commit is contained in:
Martin Hořeňovský 2024-04-08 13:15:31 +02:00
parent 71b11c4e33
commit 05fb437cbb
No known key found for this signature in database
GPG Key ID: DE48307B8B0D381A
2 changed files with 34 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
tests/SelfTest/UsageTests/Compilation.tests.cpp
View File

@ -405,14 +405,26 @@ TEST_CASE( "#2555 - types that can only be compared with 0 literal implemented a
// have the ambiguity issue) for `==` and `!=`. // have the ambiguity issue) for `==` and `!=`.
TEST_CASE( "Comparing const instances of type registered with capture_by_value", TEST_CASE( "Comparing const instances of type registered with capture_by_value",
"[regression][approvals][compilation]" ) { "[regression][approvals][compilation]" ) {
auto const const_Lit0Type_1 = TypeWithLit0Comparisons{}; SECTION("Type with consteval-int constructor") {
auto const const_Lit0Type_2 = TypeWithLit0Comparisons{}; auto const const_Lit0Type_1 = TypeWithConstevalLit0Comparison{};
REQUIRE( const_Lit0Type_1 == const_Lit0Type_2 ); auto const const_Lit0Type_2 = TypeWithConstevalLit0Comparison{};
REQUIRE( const_Lit0Type_1 <= const_Lit0Type_2 ); REQUIRE( const_Lit0Type_1 == const_Lit0Type_2 );
REQUIRE( const_Lit0Type_1 < const_Lit0Type_2 ); REQUIRE( const_Lit0Type_1 <= const_Lit0Type_2 );
REQUIRE( const_Lit0Type_1 >= const_Lit0Type_2 ); REQUIRE( const_Lit0Type_1 < const_Lit0Type_2 );
REQUIRE( const_Lit0Type_1 > const_Lit0Type_2 ); REQUIRE( const_Lit0Type_1 >= const_Lit0Type_2 );
REQUIRE_FALSE( const_Lit0Type_1 != const_Lit0Type_2 ); REQUIRE( const_Lit0Type_1 > const_Lit0Type_2 );
REQUIRE( const_Lit0Type_1 != const_Lit0Type_2 );
}
SECTION("Type with constexpr-int constructor") {
auto const const_Lit0Type_1 = TypeWithLit0Comparisons{};
auto const const_Lit0Type_2 = TypeWithLit0Comparisons{};
REQUIRE( const_Lit0Type_1 == const_Lit0Type_2 );
REQUIRE( const_Lit0Type_1 <= const_Lit0Type_2 );
REQUIRE( const_Lit0Type_1 < const_Lit0Type_2 );
REQUIRE( const_Lit0Type_1 >= const_Lit0Type_2 );
REQUIRE( const_Lit0Type_1 > const_Lit0Type_2 );
REQUIRE( const_Lit0Type_1 != const_Lit0Type_2 );
}
} }
#endif // C++20 consteval #endif // C++20 consteval

22
tests/SelfTest/helpers/type_with_lit_0_comparisons.hpp
View File

@ -26,14 +26,20 @@ struct ZeroLiteralAsPointer {
struct TypeWithLit0Comparisons { struct TypeWithLit0Comparisons {
#define DEFINE_COMP_OP( op ) \ #define DEFINE_COMP_OP( op ) \
constexpr friend bool operator op( TypeWithLit0Comparisons, \ constexpr friend bool operator op( TypeWithLit0Comparisons, \
ZeroLiteralAsPointer ) { \ ZeroLiteralAsPointer ) { \
return true; \ return true; \
} \ } \
constexpr friend bool operator op( ZeroLiteralAsPointer, \ constexpr friend bool operator op( ZeroLiteralAsPointer, \
TypeWithLit0Comparisons ) { \ TypeWithLit0Comparisons ) { \
return false; \ return false; \
} \
/* std::orderings only have these for ==, but we add them for all \
operators so we can test all overloads for decomposer */ \
constexpr friend bool operator op( TypeWithLit0Comparisons, \
TypeWithLit0Comparisons ) { \
return true; \
} }
DEFINE_COMP_OP( < ) DEFINE_COMP_OP( < )