mirror of
				https://github.com/catchorg/Catch2.git
				synced 2025-10-31 20:27:11 +01:00 
			
		
		
		
	Clean-up re-usable string streams
This commit is contained in:
		| @@ -87,6 +87,7 @@ namespace Catch { | ||||
|         delete getTheRegistryHub(); | ||||
|         getTheRegistryHub() = nullptr; | ||||
|         cleanUpContext(); | ||||
|         ReusableStringStream::cleanup(); | ||||
|     } | ||||
|     std::string translateActiveException() { | ||||
|         return getRegistryHub().getExceptionTranslatorRegistry().translateActiveException(); | ||||
|   | ||||
| @@ -145,6 +145,7 @@ namespace Catch { | ||||
|         std::vector<std::unique_ptr<std::ostringstream>> m_streams; | ||||
|         std::vector<std::size_t> m_unused; | ||||
|         std::ostringstream m_referenceStream; // Used for copy state/ flags from | ||||
|         static StringStreams* s_instance; | ||||
|  | ||||
|         auto add() -> std::size_t { | ||||
|             if( m_unused.empty() ) { | ||||
| @@ -165,11 +166,21 @@ namespace Catch { | ||||
|  | ||||
|         // !TBD: put in TLS | ||||
|         static auto instance() -> StringStreams& { | ||||
|             static StringStreams s_stringStreams; | ||||
|             return s_stringStreams; | ||||
|             if( !s_instance ) | ||||
|                 s_instance = new StringStreams(); | ||||
|             return *s_instance; | ||||
|         } | ||||
|         static void cleanup() { | ||||
|             delete s_instance; | ||||
|             s_instance = nullptr; | ||||
|         } | ||||
|     }; | ||||
|  | ||||
|     StringStreams* StringStreams::s_instance = nullptr; | ||||
|  | ||||
|     void ReusableStringStream::cleanup() { | ||||
|         StringStreams::cleanup(); | ||||
|     } | ||||
|  | ||||
|     ReusableStringStream::ReusableStringStream() | ||||
|     :   m_index( StringStreams::instance().add() ), | ||||
|   | ||||
| @@ -43,6 +43,8 @@ namespace Catch { | ||||
|             return *this; | ||||
|         } | ||||
|         auto get() -> std::ostream& { return *m_oss; } | ||||
|  | ||||
|         static void cleanup(); | ||||
|     }; | ||||
| } | ||||
|  | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 Phil Nash
					Phil Nash