3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2024-11-25 23:06:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

Decrease chance of false positive in random generator testing

Browse Source
This commit is contained in:
Martin Hořeňovský 2020-05-03 19:01:21 +02:00
parent 19ecad6f68
commit 0c223bb751
No known key found for this signature in database
GPG Key ID: DE48307B8B0D381A
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/SelfTest/IntrospectiveTests/GeneratorsImpl.tests.cpp
View File

@ -341,8 +341,9 @@ TEST_CASE("Multiple random generators in one test case output different values",
same += random1.get() == random2.get(); same += random1.get() == random2.get();
random1.next(); random2.next(); random1.next(); random2.next();
} }
// 0.5% seems like a sane bound for random identical elements within 1000 runs // Because the previous low bound failed CI couple of times,
REQUIRE(same < 5); // we use a very high threshold of 20% before failure is reported.
REQUIRE(same < 200);
} }
SECTION("Float") { SECTION("Float") {
auto random1 = Catch::Generators::random(0., 1000.); auto random1 = Catch::Generators::random(0., 1000.);
@ -352,7 +353,8 @@ TEST_CASE("Multiple random generators in one test case output different values",
same += random1.get() == random2.get(); same += random1.get() == random2.get();
random1.next(); random2.next(); random1.next(); random2.next();
} }
// 0.5% seems like a sane bound for random identical elements within 1000 runs // Because the previous low bound failed CI couple of times,
REQUIRE(same < 5); // we use a very high threshold of 20% before failure is reported.
REQUIRE(same < 200);
} }
} }