3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2024-11-17 11:12:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Replace two dynamic_casts with static_casts

Browse Source 
This eliminates two uses of RTTI in Catch.
This commit is contained in:
Eirik Byrkjeflot Anonsen 2016-04-04 18:29:07 +02:00
parent c984fc3ecd
commit 162ea1a49a
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
include/internal/catch_test_case_tracker.hpp
View File

@ -234,10 +234,8 @@ namespace TestCaseTracking {
SectionTracker* section = CATCH_NULL; SectionTracker* section = CATCH_NULL;
ITracker& currentTracker = ctx.currentTracker(); ITracker& currentTracker = ctx.currentTracker();
if( ITracker* childTracker = currentTracker.findChild( name ) ) { if( ITracker* childTracker = currentTracker.findChild( name ) )
section = dynamic_cast<SectionTracker*>( childTracker ); section = static_cast<SectionTracker*>( childTracker );
assert( section );
}
else { else {
section = new SectionTracker( name, ctx, &currentTracker ); section = new SectionTracker( name, ctx, &currentTracker );
currentTracker.addChild( section ); currentTracker.addChild( section );
@ -265,10 +263,8 @@ namespace TestCaseTracking {
IndexTracker* tracker = CATCH_NULL; IndexTracker* tracker = CATCH_NULL;
ITracker& currentTracker = ctx.currentTracker(); ITracker& currentTracker = ctx.currentTracker();
if( ITracker* childTracker = currentTracker.findChild( name ) ) { if( ITracker* childTracker = currentTracker.findChild( name ) )
tracker = dynamic_cast<IndexTracker*>( childTracker ); tracker = static_cast<IndexTracker*>( childTracker );
assert( tracker );
}
else { else {
tracker = new IndexTracker( name, ctx, &currentTracker, size ); tracker = new IndexTracker( name, ctx, &currentTracker, size );
currentTracker.addChild( tracker ); currentTracker.addChild( tracker );