Cleanup some stuff found by MSVC's /analyze

* Added some missing `noexcept`s on custom destructors.
* Fixed `std::move` being called on a const-reference.
* Initialized `ScopedMessage::m_moved` in class definition, instead
of doing so in constructors explicitly.
* Turned some `enum`s into `enum class`es.
* Initialized `StreamingReporterBase::currentTestCaseInfo` in class
definition.
* Some cleanups in SelfTest code.

src/catch2/benchmark/detail/catch_benchmark_function.hpp

@@ -81,14 +81,15 @@ namespace Catch {
                     BenchmarkFunction(Fun&& fun)
                     : f(new model<typename std::decay<Fun>::type>(std::forward<Fun>(fun))) {}
 
-                BenchmarkFunction(BenchmarkFunction&& that)
+                BenchmarkFunction( BenchmarkFunction&& that ) noexcept:
-                    : f(std::move(that.f)) {}
+                    f( std::move( that.f ) ) {}
 
                 BenchmarkFunction(BenchmarkFunction const& that)
                     : f(that.f->clone()) {}
 
-                BenchmarkFunction& operator=(BenchmarkFunction&& that) {
+                BenchmarkFunction&
-                    f = std::move(that.f);
+                operator=( BenchmarkFunction&& that ) noexcept {
+                    f = std::move( that.f );
                     return *this;
                 }
 

src/catch2/catch_message.cpp

@@ -26,16 +26,14 @@ namespace Catch {
     ////////////////////////////////////////////////////////////////////////////
 
 
-    ScopedMessage::ScopedMessage( MessageBuilder const& builder )
+    ScopedMessage::ScopedMessage( MessageBuilder const& builder ):
-    : m_info( builder.m_info ), m_moved()
+        m_info( builder.m_info ) {
-    {
         m_info.message = builder.m_stream.str();
         getResultCapture().pushScopedMessage( m_info );
     }
 
-    ScopedMessage::ScopedMessage( ScopedMessage&& old )
+    ScopedMessage::ScopedMessage( ScopedMessage&& old ) noexcept:
-    : m_info( old.m_info ), m_moved()
+        m_info( std::move( old.m_info ) ) {
-    {
         old.m_moved = true;
     }
 

src/catch2/catch_message.hpp

@@ -49,11 +49,11 @@ namespace Catch {
     public:
         explicit ScopedMessage( MessageBuilder const& builder );
         ScopedMessage( ScopedMessage& duplicate ) = delete;
-        ScopedMessage( ScopedMessage&& old );
+        ScopedMessage( ScopedMessage&& old ) noexcept;
         ~ScopedMessage();
 
         MessageInfo m_info;
-        bool m_moved;
+        bool m_moved = false;
     };
 
     class Capturer {

src/catch2/internal/catch_list.cpp

@@ -41,7 +41,7 @@ namespace Catch {
             }
 
             std::vector<TagInfo> infos; infos.reserve(tagCounts.size());
-            for (auto const& tagc : tagCounts) {
+            for (auto& tagc : tagCounts) {
                 infos.push_back(std::move(tagc.second));
             }
 

src/catch2/reporters/catch_reporter_bases.hpp

@@ -71,7 +71,7 @@ namespace Catch {
 
         LazyStat<TestRunInfo> currentTestRunInfo;
         LazyStat<GroupInfo> currentGroupInfo;
-        TestCaseInfo const* currentTestCaseInfo;
+        TestCaseInfo const* currentTestCaseInfo = nullptr;
 
         std::vector<SectionInfo> m_sectionStack;
     };

src/catch2/reporters/catch_reporter_console.cpp

@@ -192,8 +192,9 @@ std::size_t& findMax(std::size_t& i, std::size_t& j, std::size_t& k) {
         return k;
 }
 
+enum class Justification { Left, Right };
+
 struct ColumnInfo {
-    enum Justification { Left, Right };
     std::string name;
     int width;
     Justification justification;
@@ -335,7 +336,7 @@ public:
         auto padding = (strSize + 1 < static_cast<std::size_t>(colInfo.width))
             ? std::string(colInfo.width - (strSize + 1), ' ')
             : std::string();
-        if (colInfo.justification == ColumnInfo::Left)
+        if (colInfo.justification == Justification::Left)
             tp.m_os << colStr << padding << ' ';
         else
             tp.m_os << padding << colStr << ' ';
@@ -358,19 +359,19 @@ ConsoleReporter::ConsoleReporter(ReporterConfig const& config)
         if (config.fullConfig()->benchmarkNoAnalysis())
         {
             return{
-                { "benchmark name", CATCH_CONFIG_CONSOLE_WIDTH - 43, ColumnInfo::Left },
+                { "benchmark name", CATCH_CONFIG_CONSOLE_WIDTH - 43, Justification::Left },
-                { "     samples", 14, ColumnInfo::Right },
+                { "     samples", 14, Justification::Right },
-                { "  iterations", 14, ColumnInfo::Right },
+                { "  iterations", 14, Justification::Right },
-                { "        mean", 14, ColumnInfo::Right }
+                { "        mean", 14, Justification::Right }
             };
         }
         else
         {
             return{
-                { "benchmark name", CATCH_CONFIG_CONSOLE_WIDTH - 43, ColumnInfo::Left },
+                { "benchmark name", CATCH_CONFIG_CONSOLE_WIDTH - 43, Justification::Left },
-                { "samples      mean       std dev", 14, ColumnInfo::Right },
+                { "samples      mean       std dev", 14, Justification::Right },
-                { "iterations   low mean   low std dev", 14, ColumnInfo::Right },
+                { "iterations   low mean   low std dev", 14, Justification::Right },
-                { "estimated    high mean  high std dev", 14, ColumnInfo::Right }
+                { "estimated    high mean  high std dev", 14, Justification::Right }
             };
         }
     }())) {}

tests/SelfTest/IntrospectiveTests/UniquePtr.tests.cpp

@@ -104,10 +104,10 @@ namespace {
         move_detector(move_detector const& rhs) = default;
         move_detector& operator=(move_detector const& rhs) = default;
 
-        move_detector(move_detector&& rhs) {
+        move_detector(move_detector&& rhs) noexcept {
             rhs.has_moved = true;
         }
-        move_detector& operator=(move_detector&& rhs) {
+        move_detector& operator=(move_detector&& rhs) noexcept {
             rhs.has_moved = true;
             return *this;
         }

tests/SelfTest/UsageTests/Tricky.tests.cpp

@@ -185,7 +185,7 @@ struct Obj
 {
     Obj():prop(&p){}
 
-    int p;
+    int p = 0;
     int* prop;
 };