3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2024-11-22 13:26:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add Wsuggest-override to warning flags

Browse Source
This commit is contained in:
Martin Hořeňovský 2020-05-13 13:15:37 +02:00
parent ae0ba81423
commit 29d4b3768c
No known key found for this signature in database
GPG Key ID: DE48307B8B0D381A
4 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CMake/MiscFunctions.cmake
View File

@ -61,6 +61,7 @@ function(add_warnings_to_targets targets)
"-Wunused-function"
"-Wcall-to-pure-virtual-from-ctor-dtor"
"-Wdeprecated-register"
"-Wsuggest-override"
)
foreach(warning ${CHECKED_WARNING_FLAGS})
add_cxx_flag_if_supported_to_targets(${warning} "${targets}")

18
src/catch2/internal/catch_clara.hpp
View File

@ -16,20 +16,22 @@
#endif
#define CATCH_CLARA_TEXTFLOW_CONFIG_CONSOLE_WIDTH CATCH_CONFIG_CONSOLE_WIDTH-1
#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wweak-vtables"
#pragma clang diagnostic ignored "-Wexit-time-destructors"
#pragma clang diagnostic ignored "-Wshadow"
#pragma clang diagnostic ignored "-Wdeprecated"
#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wweak-vtables"
#pragma clang diagnostic ignored "-Wexit-time-destructors"
#pragma clang diagnostic ignored "-Wshadow"
#pragma clang diagnostic ignored "-Wdeprecated"
#endif
#include <catch2/internal/catch_clara_upstream.hpp>
#ifdef __clang__
#pragma clang diagnostic pop
#if defined(__clang__)
#pragma clang diagnostic pop
#endif
// Restore Clara's value for console width, if present
#ifdef CATCH_TEMP_CLARA_CONFIG_CONSOLE_WIDTH
#define CATCH_CLARA_TEXTFLOW_CONFIG_CONSOLE_WIDTH CATCH_TEMP_CLARA_CONFIG_CONSOLE_WIDTH

2
src/catch2/internal/catch_clara_upstream.hpp
View File

@ -705,7 +705,7 @@ namespace detail {
};
struct BoundFlagRefBase : BoundRef {
virtual auto setFlag( bool flag ) -> ParserResult = 0;
virtual auto isFlag() const -> bool { return true; }
bool isFlag() const override { return true; }
};
template<typename T>

2
src/catch2/internal/catch_run_context.hpp
View File

@ -105,7 +105,7 @@ namespace Catch {
public:
// !TBD We need to do this another way!
bool aborting() const final;
bool aborting() const override;
private: