3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2024-11-25 14:56:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

Increase timing window for min duration tests to 1s

Browse Source 
This test tends to be brittle on Mac CI machines, which are
heavily loaded and bursty. Since the tests are only run as part
of the "extra tests" test set, this increase should not have
a significant impact on the total duration of CI runs.
This commit is contained in:
Martin Hořeňovský 2021-02-20 23:08:58 +01:00
parent 749d953712
commit 3afea8128a
No known key found for this signature in database
GPG Key ID: DE48307B8B0D381A
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/ExtraTests/CMakeLists.txt
View File

@ -11,11 +11,11 @@ message( STATUS "Extra tests included" )
# The MinDuration reporting tests do not need separate compilation, but # The MinDuration reporting tests do not need separate compilation, but
# they have non-trivial execution time, so they are categorized as # they have non-trivial execution time, so they are categorized as
# extra tests, so that they are run less. # extra tests, so that they are run less.
add_test(NAME MinDuration::SimpleThreshold COMMAND $<TARGET_FILE:SelfTest> --min-duration 0.245 [min_duration_test]) add_test(NAME MinDuration::SimpleThreshold COMMAND $<TARGET_FILE:SelfTest> --min-duration 0.950 [min_duration_test])
set_tests_properties( set_tests_properties(
MinDuration::SimpleThreshold MinDuration::SimpleThreshold
PROPERTIES PROPERTIES
PASS_REGULAR_EXPRESSION "s: sleep_for_250ms" PASS_REGULAR_EXPRESSION "s: sleep_for_1000ms"
FAIL_REGULAR_EXPRESSION "sleep_for_100ms" FAIL_REGULAR_EXPRESSION "sleep_for_100ms"
RUN_SERIAL ON # The test is timing sensitive, so we want to run it RUN_SERIAL ON # The test is timing sensitive, so we want to run it
# serially to avoid false positives on oversubscribed machines # serially to avoid false positives on oversubscribed machines

4
tests/SelfTest/TimingTests/Sleep.tests.cpp
View File

@ -16,8 +16,8 @@ TEST_CASE( "sleep_for_100ms", "[.min_duration_test][approvals]" )
CHECK( true ); CHECK( true );
} }
TEST_CASE( "sleep_for_250ms", "[.min_duration_test][approvals]" ) TEST_CASE( "sleep_for_1000ms", "[.min_duration_test][approvals]" )
{ {
std::this_thread::sleep_for( std::chrono::milliseconds( 250 ) ); std::this_thread::sleep_for( std::chrono::milliseconds( 1'000 ) );
CHECK( true ); CHECK( true );
} }