3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2024-11-26 07:16:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix reporter parser spec to use the right key for colour-mode

Browse Source
This commit is contained in:
Martin Hořeňovský 2022-04-06 15:17:17 +02:00
parent a51fd07bd0
commit 3c06bcb374
No known key found for this signature in database
GPG Key ID: DE48307B8B0D381A
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/catch2/internal/catch_reporter_spec_parser.cpp
View File

@ -139,7 +139,7 @@ namespace Catch {
return {}; return {};
} }
outputFileName = static_cast<std::string>( value ); outputFileName = static_cast<std::string>( value );
} else if ( key == "colour" ) { } else if ( key == "colour-mode" ) {
// Duplicated key // Duplicated key
if ( colourMode ) { if ( colourMode ) {
return {}; return {};

6
tests/SelfTest/IntrospectiveTests/CmdLineHelpers.tests.cpp
View File

@ -81,7 +81,7 @@ TEST_CASE("Parsing reporter specs", "[cli][reporter-spec][approvals]") {
{}, {},
{ { "Xk1"s, "v1"s }, { "Xk2"s, "=v2"s } } ) ); { { "Xk1"s, "v1"s }, { "Xk2"s, "=v2"s } } ) );
REQUIRE( parseReporterSpec( REQUIRE( parseReporterSpec(
"Foo:bar:reporter::colour=ansi::Xk 1=v 1::Xk2=v:3" ) == "Foo:bar:reporter::colour-mode=ansi::Xk 1=v 1::Xk2=v:3" ) ==
ReporterSpec( "Foo:bar:reporter", ReporterSpec( "Foo:bar:reporter",
{}, {},
Catch::ColourMode::ANSI, Catch::ColourMode::ANSI,
@ -93,9 +93,9 @@ TEST_CASE("Parsing reporter specs", "[cli][reporter-spec][approvals]") {
// Unknown Catch2 arg (should be "out") // Unknown Catch2 arg (should be "out")
REQUIRE_FALSE( parseReporterSpec( "reporter::output=filename" ) ); REQUIRE_FALSE( parseReporterSpec( "reporter::output=filename" ) );
// Wrong colour spec // Wrong colour spec
REQUIRE_FALSE( parseReporterSpec( "reporter::colour=custom" ) ); REQUIRE_FALSE( parseReporterSpec( "reporter::colour-mode=custom" ) );
// Duplicated colour spec // Duplicated colour spec
REQUIRE_FALSE( parseReporterSpec( "reporter::colour=ansi::colour=ansi" ) ); REQUIRE_FALSE( parseReporterSpec( "reporter::colour-mode=ansi::colour-mode=ansi" ) );
// Duplicated out arg // Duplicated out arg
REQUIRE_FALSE( parseReporterSpec( "reporter::out=f.txt::out=z.txt" ) ); REQUIRE_FALSE( parseReporterSpec( "reporter::out=f.txt::out=z.txt" ) );
// Duplicated custom arg // Duplicated custom arg