3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2025-08-01 21:05:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix ulp distance calculation for numbers with different signs

Browse Source 
This is a simplification of the fix proposed in #2152, with the
critical function split out so that it can be tested directly,
without having to go through the ULP matcher.

Closes #2152
This commit is contained in:
Martin Hořeňovský
2021-07-26 22:01:04 +02:00
parent 6f21a3609c
commit 3d1cf95b32
19 changed files with 502 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/SelfTest/UsageTests/Matchers.tests.cpp
View File

@@ -4,6 +4,7 @@
*/
#include <catch2/catch_test_macros.hpp>
#include <catch2/catch_template_test_macros.hpp>
#include <catch2/matchers/catch_matchers_exception.hpp>
#include <catch2/matchers/catch_matchers_floating_point.hpp>
#include <catch2/matchers/catch_matchers_predicate.hpp>
@@ -465,6 +466,7 @@ TEST_CASE( "Floating point matchers: float", "[matchers][floating-point]" ) {
}
SECTION( "ULPs" ) {
REQUIRE_THAT( 1.f, WithinULP( 1.f, 0 ) );
REQUIRE_THAT(-1.f, WithinULP( -1.f, 0 ) );
REQUIRE_THAT( nextafter( 1.f, 2.f ), WithinULP( 1.f, 1 ) );
REQUIRE_THAT( 0.f, WithinULP( nextafter( 0.f, 1.f ), 1 ) );
@@ -1081,3 +1083,17 @@ TEST_CASE( "Matchers can take references",
#ifdef __clang__
# pragma clang diagnostic pop
#endif
TEMPLATE_TEST_CASE(
"#2152 - ULP checks between differently signed values were wrong",
"[matchers][floating-point][ulp]",
float,
double ) {
using Catch::Matchers::WithinULP;
static constexpr TestType smallest_non_zero =
std::numeric_limits<TestType>::denorm_min();
CHECK_THAT( smallest_non_zero, WithinULP( -smallest_non_zero, 2 ) );
CHECK_THAT( smallest_non_zero, !WithinULP( -smallest_non_zero, 1 ) );
}