From 3e9c6fec222a5b307a712ba47dc4e930b37ad4e5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Ho=C5=99e=C5=88ovsk=C3=BD?= Date: Sat, 2 Oct 2021 11:45:19 +0200 Subject: [PATCH] Remove XmlWriter::writeBlankLine There is no good reason to provide a "add empty line" primitive for writing XML documents, and the fact that it remains unused after all the time it was provided only confirms this further. --- src/catch2/internal/catch_xmlwriter.cpp | 6 ------ src/catch2/internal/catch_xmlwriter.hpp | 2 -- 2 files changed, 8 deletions(-) diff --git a/src/catch2/internal/catch_xmlwriter.cpp b/src/catch2/internal/catch_xmlwriter.cpp index 1be19bfc..3aecd04a 100644 --- a/src/catch2/internal/catch_xmlwriter.cpp +++ b/src/catch2/internal/catch_xmlwriter.cpp @@ -322,12 +322,6 @@ namespace { m_os << R"()" << '\n'; } - XmlWriter& XmlWriter::writeBlankLine() { - ensureTagClosed(); - m_os << '\n'; - return *this; - } - void XmlWriter::ensureTagClosed() { if( m_tagIsOpen ) { m_os << '>' << std::flush; diff --git a/src/catch2/internal/catch_xmlwriter.hpp b/src/catch2/internal/catch_xmlwriter.hpp index a939a6f3..7bfa2c39 100644 --- a/src/catch2/internal/catch_xmlwriter.hpp +++ b/src/catch2/internal/catch_xmlwriter.hpp @@ -129,8 +129,6 @@ namespace Catch { void writeStylesheetRef( StringRef url ); - XmlWriter& writeBlankLine(); - void ensureTagClosed(); private: