mirror of
				https://github.com/catchorg/Catch2.git
				synced 2025-11-03 21:49:32 +01:00 
			
		
		
		
	Update handling of __JETBRAINS_IDE__ macro
1. Use it to conditionally define CATCH_INTERNAL_CONFIG_COUNTER, not CATCH_CONFIG_COUNTER, as __JETBRAINS_IDE__ is similar to compiler-provided macros, not to user-provided ones. 2. Since __COUNTER__ will work starting with CLion 2017.3, use it when possible (and hopefully remove this check altogether at some point).
This commit is contained in:
		
				
					committed by
					
						
						Martin Hořeňovský
					
				
			
			
				
	
			
			
			
						parent
						
							eea9e1efd7
						
					
				
				
					commit
					44244713f1
				
			@@ -92,17 +92,16 @@
 | 
			
		||||
 | 
			
		||||
////////////////////////////////////////////////////////////////////////////////
 | 
			
		||||
 | 
			
		||||
// All supported compilers support COUNTER macro,
 | 
			
		||||
//but user still might want to turn it off
 | 
			
		||||
#define CATCH_INTERNAL_CONFIG_COUNTER
 | 
			
		||||
// Use of __COUNTER__ is suppressed during code analysis in
 | 
			
		||||
// CLion/AppCode 2017.2.x and former, because __COUNTER__ is not properly
 | 
			
		||||
// handled by it.
 | 
			
		||||
// Otherwise all supported compilers support COUNTER macro,
 | 
			
		||||
// but user still might want to turn it off
 | 
			
		||||
#if ( !defined(__JETBRAINS_IDE__) || __JETBRAINS_IDE__ >= 20170300L )
 | 
			
		||||
    #define CATCH_INTERNAL_CONFIG_COUNTER
 | 
			
		||||
#endif
 | 
			
		||||
 | 
			
		||||
 | 
			
		||||
// Now set the actual defines based on the above + anything the user has configured
 | 
			
		||||
 | 
			
		||||
// Use of __COUNTER__ is suppressed if __JETBRAINS_IDE__ is #defined (meaning we're being parsed by a JetBrains IDE for
 | 
			
		||||
// analytics) because, at time of writing, __COUNTER__ is not properly handled by it.
 | 
			
		||||
// This does not affect compilation
 | 
			
		||||
#if defined(CATCH_INTERNAL_CONFIG_COUNTER) && !defined(CATCH_CONFIG_NO_COUNTER) && !defined(CATCH_CONFIG_COUNTER) && !defined(__JETBRAINS_IDE__)
 | 
			
		||||
#if defined(CATCH_INTERNAL_CONFIG_COUNTER) && !defined(CATCH_CONFIG_NO_COUNTER) && !defined(CATCH_CONFIG_COUNTER)
 | 
			
		||||
#   define CATCH_CONFIG_COUNTER
 | 
			
		||||
#endif
 | 
			
		||||
#if defined(CATCH_INTERNAL_CONFIG_WINDOWS_SEH) && !defined(CATCH_CONFIG_NO_WINDOWS_SEH) && !defined(CATCH_CONFIG_WINDOWS_SEH)
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user