mirror of
				https://github.com/catchorg/Catch2.git
				synced 2025-10-31 20:27:11 +01:00 
			
		
		
		
	Approved changes due to "No assertions" warnings now firing correctly on inner sections
This commit is contained in:
		| @@ -494,7 +494,27 @@ explicitly with message: | ||||
|   Message from section two | ||||
|  | ||||
| Message from section one | ||||
| ------------------------------------------------------------------------------- | ||||
| Standard output from all sections is reported | ||||
|   one | ||||
| ------------------------------------------------------------------------------- | ||||
| MessageTests.cpp:<line number> | ||||
| ............................................................................... | ||||
|  | ||||
|  | ||||
| No assertions in section 'one' | ||||
|  | ||||
| Message from section two | ||||
| ------------------------------------------------------------------------------- | ||||
| Standard output from all sections is reported | ||||
|   two | ||||
| ------------------------------------------------------------------------------- | ||||
| MessageTests.cpp:<line number> | ||||
| ............................................................................... | ||||
|  | ||||
|  | ||||
| No assertions in section 'two' | ||||
|  | ||||
| ------------------------------------------------------------------------------- | ||||
| SCOPED_INFO is reset for each loop | ||||
| ------------------------------------------------------------------------------- | ||||
| @@ -558,6 +578,38 @@ MiscTests.cpp:<line number>: FAILED: | ||||
| with expansion: | ||||
|   1 == 2 | ||||
|  | ||||
| ------------------------------------------------------------------------------- | ||||
| even more nested SECTION tests | ||||
|   c | ||||
|   d (leaf) | ||||
| ------------------------------------------------------------------------------- | ||||
| MiscTests.cpp:<line number> | ||||
| ............................................................................... | ||||
|  | ||||
|  | ||||
| No assertions in section 'd (leaf)' | ||||
|  | ||||
| ------------------------------------------------------------------------------- | ||||
| even more nested SECTION tests | ||||
|   c | ||||
|   e (leaf) | ||||
| ------------------------------------------------------------------------------- | ||||
| MiscTests.cpp:<line number> | ||||
| ............................................................................... | ||||
|  | ||||
|  | ||||
| No assertions in section 'e (leaf)' | ||||
|  | ||||
| ------------------------------------------------------------------------------- | ||||
| even more nested SECTION tests | ||||
|   f (leaf) | ||||
| ------------------------------------------------------------------------------- | ||||
| MiscTests.cpp:<line number> | ||||
| ............................................................................... | ||||
|  | ||||
|  | ||||
| No assertions in section 'f (leaf)' | ||||
|  | ||||
| ------------------------------------------------------------------------------- | ||||
| looped SECTION tests | ||||
|   s1 | ||||
| @@ -652,6 +704,26 @@ MiscTests.cpp:<line number>: FAILED: | ||||
| with expansion: | ||||
|   false | ||||
|  | ||||
| ------------------------------------------------------------------------------- | ||||
| xmlentitycheck | ||||
|   embedded xml | ||||
| ------------------------------------------------------------------------------- | ||||
| MiscTests.cpp:<line number> | ||||
| ............................................................................... | ||||
|  | ||||
|  | ||||
| No assertions in section 'embedded xml' | ||||
|  | ||||
| ------------------------------------------------------------------------------- | ||||
| xmlentitycheck | ||||
|   encoded chars | ||||
| ------------------------------------------------------------------------------- | ||||
| MiscTests.cpp:<line number> | ||||
| ............................................................................... | ||||
|  | ||||
|  | ||||
| No assertions in section 'encoded chars' | ||||
|  | ||||
| ------------------------------------------------------------------------------- | ||||
| send a single char to INFO | ||||
| ------------------------------------------------------------------------------- | ||||
| @@ -797,6 +869,6 @@ with expansion: | ||||
|   "first" == "second" | ||||
|  | ||||
| =============================================================================== | ||||
| test cases: 159 | 119 passed | 39 failed |  1 failed as expected | ||||
| assertions: 788 | 695 passed | 80 failed | 13 failed as expected | ||||
| test cases: 160 | 117 passed | 42 failed |  1 failed as expected | ||||
| assertions: 927 | 827 passed | 87 failed | 13 failed as expected | ||||
|  | ||||
|   | ||||
										
											
												File diff suppressed because it is too large
												Load Diff
											
										
									
								
							| @@ -1,5 +1,5 @@ | ||||
| <testsuites> | ||||
|   <testsuite name="CatchSelfTest" errors="12" failures="88" tests="808" hostname="tbd" time="{duration}" timestamp="tbd"> | ||||
|   <testsuite name="CatchSelfTest" errors="12" failures="68" tests="920" hostname="tbd" time="{duration}" timestamp="tbd"> | ||||
|     <testcase classname="global" name="toString(enum)" time="{duration}"/> | ||||
|     <testcase classname="global" name="toString(enum w/operator<<)" time="{duration}"/> | ||||
|     <testcase classname="global" name="toString(enum class)" time="{duration}"/> | ||||
| @@ -341,6 +341,8 @@ MessageTests.cpp:<line number> | ||||
| MiscTests.cpp:<line number> | ||||
|       </failure> | ||||
|     </testcase> | ||||
|     <testcase classname="more nested SECTION tests" name="s1/s3" time="{duration}"/> | ||||
|     <testcase classname="more nested SECTION tests" name="s1/s4" time="{duration}"/> | ||||
|     <testcase classname="looped SECTION tests" name="s1" time="{duration}"> | ||||
|       <failure message="0 > 1" type="CHECK"> | ||||
| MiscTests.cpp:<line number> | ||||
| @@ -566,6 +568,23 @@ TrickyTests.cpp:<line number> | ||||
|     <testcase classname="global" name="toString( vectors<has_toString )" time="{duration}"/> | ||||
|     <testcase classname="global" name="toString( vectors<has_maker )" time="{duration}"/> | ||||
|     <testcase classname="global" name="toString( vectors<has_maker_and_toString )" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="root" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="successfully close one section" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="fail one section" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="fail one section/re-enter after failed section" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="fail one section/re-enter after failed section and find next section" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="successfully close one section, then find another" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="successfully close one section, then find another/Re-enter - skips S1 and enters S2" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="successfully close one section, then find another/Re-enter - skips S1 and enters S2/Successfully close S2" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="successfully close one section, then find another/Re-enter - skips S1 and enters S2/fail S2" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="open a nested section" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="start a generator" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="start a generator/close outer section" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="start a generator/close outer section/Re-enter for second generation" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="start a generator/Start a new inner section" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="start a generator/Start a new inner section/Re-enter for second generation" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="start a generator/Fail an inner section" time="{duration}"/> | ||||
|     <testcase classname="Tracker" name="start a generator/Fail an inner section/Re-enter for second generation" time="{duration}"/> | ||||
|     <testcase classname="global" name="std::pair<int,std::string> -> toString" time="{duration}"/> | ||||
|     <testcase classname="global" name="std::pair<int,const std::string> -> toString" time="{duration}"/> | ||||
|     <testcase classname="global" name="std::vector<std::pair<std::string,int> > -> toString" time="{duration}"/> | ||||
|   | ||||
										
											
												File diff suppressed because it is too large
												Load Diff
											
										
									
								
							
		Reference in New Issue
	
	Block a user
	 Phil Nash
					Phil Nash