3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2024-11-22 21:36:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove Config::openStream function

Browse Source 
It has become completely vestigial, as it only ever passed-through
the argument down to a different function, and being private
member function, it didn't even introduce a useful compilation
firewall.
This commit is contained in:
Martin Hořeňovský 2022-04-07 12:45:05 +02:00
parent 46b3f7ee5f
commit 4b78157981
No known key found for this signature in database
GPG Key ID: DE48307B8B0D381A
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/catch2/catch_config.cpp
View File

@ -79,10 +79,10 @@ namespace Catch {
defaultOutputUsed = true; defaultOutputUsed = true;
m_reporterStreams.push_back( m_reporterStreams.push_back(
openStream( data.defaultOutputFilename ) ); makeStream( data.defaultOutputFilename ) );
} else { } else {
m_reporterStreams.push_back( m_reporterStreams.push_back(
openStream( *reporterSpec.outputFile() ) ); makeStream( *reporterSpec.outputFile() ) );
} }
} }
} }
@ -139,8 +139,4 @@ namespace Catch {
unsigned int Config::benchmarkResamples() const { return m_data.benchmarkResamples; } unsigned int Config::benchmarkResamples() const { return m_data.benchmarkResamples; }
std::chrono::milliseconds Config::benchmarkWarmupTime() const { return std::chrono::milliseconds(m_data.benchmarkWarmupTime); } std::chrono::milliseconds Config::benchmarkWarmupTime() const { return std::chrono::milliseconds(m_data.benchmarkWarmupTime); }
Detail::unique_ptr<IStream const> Config::openStream(std::string const& outputFileName) {
return Catch::makeStream(outputFileName);
}
} // end namespace Catch } // end namespace Catch

1
src/catch2/catch_config.hpp
View File

@ -116,7 +116,6 @@ namespace Catch {
std::chrono::milliseconds benchmarkWarmupTime() const override; std::chrono::milliseconds benchmarkWarmupTime() const override;
private: private:
Detail::unique_ptr<IStream const> openStream(std::string const& outputFileName);
ConfigData m_data; ConfigData m_data;
std::vector<Detail::unique_ptr<IStream const>> m_reporterStreams; std::vector<Detail::unique_ptr<IStream const>> m_reporterStreams;