From 4f14922aa38f88ad5135c169cdf1b723cdfd26ea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Ho=C5=99e=C5=88ovsk=C3=BD?= Date: Wed, 11 Nov 2020 20:59:28 +0100 Subject: [PATCH] Don't use shared_ptr to store test run info in CumulativeReporterBase Part of #2089 --- src/catch2/reporters/catch_reporter_cumulative_base.cpp | 4 ++-- src/catch2/reporters/catch_reporter_cumulative_base.hpp | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/catch2/reporters/catch_reporter_cumulative_base.cpp b/src/catch2/reporters/catch_reporter_cumulative_base.cpp index dabf1a4e..dcb57fc2 100644 --- a/src/catch2/reporters/catch_reporter_cumulative_base.cpp +++ b/src/catch2/reporters/catch_reporter_cumulative_base.cpp @@ -105,9 +105,9 @@ namespace Catch { } void CumulativeReporterBase::testRunEnded( TestRunStats const& testRunStats ) { - auto node = std::make_shared( testRunStats ); + auto node = Detail::make_unique( testRunStats ); node->children.swap( m_testGroups ); - m_testRuns.push_back( node ); + m_testRuns.push_back( std::move(node) ); testRunEndedCumulative(); } diff --git a/src/catch2/reporters/catch_reporter_cumulative_base.hpp b/src/catch2/reporters/catch_reporter_cumulative_base.hpp index 2f5fa5fb..8897523e 100644 --- a/src/catch2/reporters/catch_reporter_cumulative_base.hpp +++ b/src/catch2/reporters/catch_reporter_cumulative_base.hpp @@ -9,6 +9,7 @@ #define CATCH_REPORTER_CUMULATIVE_BASE_HPP_INCLUDED #include +#include #include #include @@ -77,7 +78,7 @@ namespace Catch { std::vector> m_testCases; std::vector> m_testGroups; - std::vector> m_testRuns; + std::vector> m_testRuns; std::shared_ptr m_rootSection; std::shared_ptr m_deepestSection;