From 595bf9864e4274bd8a4261b733a5d4576e070f19 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Ho=C5=99e=C5=88ovsk=C3=BD?= Date: Mon, 22 Jul 2024 10:19:27 +0200 Subject: [PATCH] Update to macos-12 GHA image Since the last time, macos-12 has fixed the toolchain's linker crash bug, so we can update here. macos-13 has a new and exciting bug when unwinding exceptions in binaries compiled with GCC, so we cannot update all the way at this time. --- .github/workflows/mac-builds.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/mac-builds.yml b/.github/workflows/mac-builds.yml index 259d8b36..8f0e502a 100644 --- a/.github/workflows/mac-builds.yml +++ b/.github/workflows/mac-builds.yml @@ -4,11 +4,7 @@ on: [push, pull_request] jobs: build: - # macos-12 updated to a toolchain that crashes when linking the - # test binary. This seems to be a known bug in that version, - # and will eventually get fixed in an update. After that, we can go - # back to newer macos images. - runs-on: macos-11 + runs-on: macos-12 strategy: matrix: cxx: @@ -29,8 +25,6 @@ jobs: env: CXX: ${{matrix.cxx}} CXXFLAGS: ${{matrix.cxxflags}} - # Note: $GITHUB_WORKSPACE is distinct from ${{runner.workspace}}. - # This is important run: | cmake -Bbuild -H$GITHUB_WORKSPACE \ -DCMAKE_BUILD_TYPE=${{matrix.build_type}} \