3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2024-11-22 13:26:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash when running with --list-listeners and no registered listeners (#2442)

Browse Source 
Co-authored-by: Sergio Losilla <sergio.losilla@nt-bnct.com>
This commit is contained in:
Sergio Losilla 2022-06-02 17:11:12 +03:00 committed by GitHub
parent 40dd9dd3f4
commit 5efd327dd4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/catch2/reporters/catch_reporter_combined_tu.cpp
View File

@ -154,6 +154,12 @@ namespace Catch {
void defaultListListeners( std::ostream& out, void defaultListListeners( std::ostream& out,
std::vector<ListenerDescription> const& descriptions ) { std::vector<ListenerDescription> const& descriptions ) {
out << "Registered listeners:\n";
if(descriptions.empty()) {
return;
}
const auto maxNameLen = const auto maxNameLen =
std::max_element( descriptions.begin(), std::max_element( descriptions.begin(),
descriptions.end(), descriptions.end(),
@ -163,7 +169,6 @@ namespace Catch {
} ) } )
->name.size(); ->name.size();
out << "Registered listeners:\n";
for ( auto const& desc : descriptions ) { for ( auto const& desc : descriptions ) {
out << TextFlow::Column( static_cast<std::string>( desc.name ) + out << TextFlow::Column( static_cast<std::string>( desc.name ) +
':' ) ':' )

5
tests/ExtraTests/CMakeLists.txt
View File

@ -459,7 +459,10 @@ add_test(
NAME TestSpecs::OverrideFailureWithEmptySpec NAME TestSpecs::OverrideFailureWithEmptySpec
COMMAND $<TARGET_FILE:NoTests> --allow-running-no-tests COMMAND $<TARGET_FILE:NoTests> --allow-running-no-tests
) )
add_test(
NAME List::Listeners::WorksWithoutRegisteredListeners
COMMAND $<TARGET_FILE:NoTests> --list-listeners
)
set( EXTRA_TEST_BINARIES set( EXTRA_TEST_BINARIES
PrefixedMacros PrefixedMacros
DisabledMacros DisabledMacros