3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2025-11-03 21:49:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Move default impls of isFooTracker to the interface

Browse Source
This commit is contained in:
Martin Hořeňovský
2021-06-10 00:02:40 +02:00
parent c064322a9d
commit 61461dfd1d
2 changed files with 16 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/catch2/internal/catch_test_case_tracker.cpp
View File

@@ -45,6 +45,8 @@ namespace TestCaseTracking {
return ( it != m_children.end() ) ? it->get() : nullptr; return ( it != m_children.end() ) ? it->get() : nullptr;
} }
bool ITracker::isSectionTracker() const { return false; }
bool ITracker::isGeneratorTracker() const { return false; }
ITracker& TrackerContext::startRun() { ITracker& TrackerContext::startRun() {
@@ -106,9 +108,6 @@ namespace TestCaseTracking {
} }
} }
bool TrackerBase::isSectionTracker() const { return false; }
bool TrackerBase::isGeneratorTracker() const { return false; }
void TrackerBase::open() { void TrackerBase::open() {
m_runState = Executing; m_runState = Executing;
moveToThis(); moveToThis();

20
src/catch2/internal/catch_test_case_tracker.hpp
View File

@@ -86,9 +86,20 @@ namespace TestCaseTracking {
virtual void openChild() = 0; virtual void openChild() = 0;
// Debug/ checking /**
virtual bool isSectionTracker() const = 0; * Returns true if the instance is a section tracker
virtual bool isGeneratorTracker() const = 0; *
* Subclasses should override to true if they are, replaces RTTI
* for internal debug checks.
*/
virtual bool isSectionTracker() const;
/**
* Returns true if the instance is a generator tracker
*
* Subclasses should override to true if they are, replaces RTTI
* for internal debug checks.
*/
virtual bool isGeneratorTracker() const;
}; };
class TrackerContext { class TrackerContext {
@@ -142,9 +153,6 @@ namespace TestCaseTracking {
void openChild() override; void openChild() override;
bool isSectionTracker() const override;
bool isGeneratorTracker() const override;
void open(); void open();
void close() override; void close() override;