From 6aac11e17d4fe662e430a8bbfd4bf6886ca7f935 Mon Sep 17 00:00:00 2001
From: Chris Thrasher <chrisjthrasher@gmail.com>
Date: Sat, 26 Apr 2025 09:11:21 -0600
Subject: [PATCH] Use CTest `--output-on-failure` flag

---
 .github/workflows/linux-other-builds.yml    | 4 +---
 .github/workflows/linux-simple-builds.yml   | 4 +---
 .github/workflows/mac-builds-m1.yml         | 4 +---
 .github/workflows/mac-builds.yml            | 4 +---
 .github/workflows/windows-simple-builds.yml | 4 +---
 5 files changed, 5 insertions(+), 15 deletions(-)

diff --git a/.github/workflows/linux-other-builds.yml b/.github/workflows/linux-other-builds.yml
index 1509528f..4b1ae69e 100644
--- a/.github/workflows/linux-other-builds.yml
+++ b/.github/workflows/linux-other-builds.yml
@@ -100,10 +100,8 @@ jobs:
       run: ninja
 
     - name: Run tests
-      env:
-          CTEST_OUTPUT_ON_FAILURE: 1
       working-directory: ${{runner.workspace}}/build
-      run: ctest -C ${{matrix.build_type}} -j `nproc` ${{matrix.other_ctest_args}}
+      run: ctest -C ${{matrix.build_type}} -j `nproc` ${{matrix.other_ctest_args}} --output-on-failure
   clang-tidy:
     name: clang-tidy ${{matrix.version}}, ${{matrix.build_description}}, C++${{matrix.std}} ${{matrix.build_type}}
     runs-on: ubuntu-22.04
diff --git a/.github/workflows/linux-simple-builds.yml b/.github/workflows/linux-simple-builds.yml
index 117de06e..73529a72 100644
--- a/.github/workflows/linux-simple-builds.yml
+++ b/.github/workflows/linux-simple-builds.yml
@@ -118,7 +118,5 @@ jobs:
       run: ninja
 
     - name: Run tests
-      env:
-          CTEST_OUTPUT_ON_FAILURE: 1
       working-directory: ${{runner.workspace}}/build
-      run: ctest -C ${{matrix.build_type}} -j `nproc`
+      run: ctest -C ${{matrix.build_type}} -j `nproc` --output-on-failure
diff --git a/.github/workflows/mac-builds-m1.yml b/.github/workflows/mac-builds-m1.yml
index 1ae36214..97fc03e1 100644
--- a/.github/workflows/mac-builds-m1.yml
+++ b/.github/workflows/mac-builds-m1.yml
@@ -39,7 +39,5 @@ jobs:
       run: make -j `sysctl -n hw.ncpu`
 
     - name: Run tests
-      env:
-          CTEST_OUTPUT_ON_FAILURE: 1
       working-directory: ${{runner.workspace}}/build
-      run: ctest -C ${{matrix.build_type}} -j `sysctl -n hw.ncpu`
+      run: ctest -C ${{matrix.build_type}} -j `sysctl -n hw.ncpu` --output-on-failure
diff --git a/.github/workflows/mac-builds.yml b/.github/workflows/mac-builds.yml
index 94e79ea7..bd64814d 100644
--- a/.github/workflows/mac-builds.yml
+++ b/.github/workflows/mac-builds.yml
@@ -43,7 +43,5 @@ jobs:
       run: make -j `sysctl -n hw.ncpu`
 
     - name: Run tests
-      env:
-          CTEST_OUTPUT_ON_FAILURE: 1
       working-directory: ${{runner.workspace}}/build
-      run: ctest -C ${{matrix.build_type}} -j `sysctl -n hw.ncpu`
+      run: ctest -C ${{matrix.build_type}} -j `sysctl -n hw.ncpu` --output-on-failure
diff --git a/.github/workflows/windows-simple-builds.yml b/.github/workflows/windows-simple-builds.yml
index 1b76a3da..85f0989a 100644
--- a/.github/workflows/windows-simple-builds.yml
+++ b/.github/workflows/windows-simple-builds.yml
@@ -32,7 +32,5 @@ jobs:
 
       - name: Run tests
         working-directory: ${{runner.workspace}}/build
-        env:
-            CTEST_OUTPUT_ON_FAILURE: 1
-        run: ctest -C ${{matrix.build_type}} -j %NUMBER_OF_PROCESSORS%
+        run: ctest -C ${{matrix.build_type}} -j %NUMBER_OF_PROCESSORS% --output-on-failure
         shell: cmd