From 722c1978554f5521ce301e26040defd1940dace6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Martin=20Ho=C5=99e=C5=88ovsk=C3=BD?=
 <martin.horenovsky@gmail.com>
Date: Sun, 1 May 2022 23:15:24 +0200
Subject: [PATCH] Enable a bunch of extra warnings

---
 CMake/CatchMiscFunctions.cmake | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/CMake/CatchMiscFunctions.cmake b/CMake/CatchMiscFunctions.cmake
index 9db8af8e..a4f5e9a8 100644
--- a/CMake/CatchMiscFunctions.cmake
+++ b/CMake/CatchMiscFunctions.cmake
@@ -48,17 +48,25 @@ function(add_warnings_to_targets targets)
           "-Wcall-to-pure-virtual-from-ctor-dtor"
           "-Wcast-align"
           "-Wcatch-value"
+          "-Wdangling"
           "-Wdeprecated"
           "-Wdeprecated-register"
+          "-Wexceptions"
           "-Wexit-time-destructors"
           "-Wextra"
           "-Wextra-semi"
           "-Wglobal-constructors"
+          "-Winit-self"
           "-Wmisleading-indentation"
+          "-Wmismatched-new-delete"
+          "-Wmismatched-return-types"
+          "-Wmismatched-tags"
           "-Wmissing-braces"
           "-Wmissing-declarations"
           "-Wmissing-noreturn"
+          "-Wnull-dereference"
           "-Wold-style-cast"
+          "-Woverloaded-virtual"
           "-Wparentheses"
           "-Wpedantic"
           "-Wreorder"
@@ -67,12 +75,21 @@ function(add_warnings_to_targets targets)
           "-Wstrict-aliasing"
           "-Wsuggest-override"
           "-Wundef"
+          "-Wuninitialized"
+          "-Wunneeded-internal-declaration"
           "-Wunreachable-code"
           "-Wunused"
           "-Wunused-function"
           "-Wunused-parameter"
           "-Wvla"
           "-Wweak-vtables"
+
+          # This is a useful warning, but our tests sometimes rely on
+          # functions being present, but not picked (e.g. various checks
+          # for stringification implementation ordering).
+          # Ergo, we should use it every now and then, but we cannot
+          # enable it by default.
+          # "-Wunused-member-function"
         )
         foreach(warning ${CHECKED_WARNING_FLAGS})
             add_cxx_flag_if_supported_to_targets(${warning} "${targets}")