3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2024-11-26 15:26:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove IStreamingReporter::isMulti query

Browse Source 
This was previously used to avoid `dynamic_cast` inside our code,
when we were creating more than one reporter, or a reporter
together with listeners. However, since then the offending code
was refactored to be smarter instead, and this query member function
is no longer needed nor used.
This commit is contained in:
Martin Hořeňovský 2020-03-09 21:07:15 +01:00
parent 9de6eae6bb
commit 727b26ab35
No known key found for this signature in database
GPG Key ID: DE48307B8B0D381A
4 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/catch2/catch_interfaces_reporter.cpp
View File

@ -112,7 +112,6 @@ namespace Catch {
TestRunStats::~TestRunStats() = default; TestRunStats::~TestRunStats() = default;
void IStreamingReporter::fatalErrorEncountered( StringRef ) {} void IStreamingReporter::fatalErrorEncountered( StringRef ) {}
bool IStreamingReporter::isMulti() const { return false; }
void IStreamingReporter::listReporters(std::vector<ReporterDescription> const& descriptions, Config const& config) { void IStreamingReporter::listReporters(std::vector<ReporterDescription> const& descriptions, Config const& config) {
Catch::cout() << "Available reporters:\n"; Catch::cout() << "Available reporters:\n";

2
src/catch2/catch_interfaces_reporter.h
View File

@ -241,8 +241,6 @@ namespace Catch {
// Default empty implementation provided // Default empty implementation provided
virtual void fatalErrorEncountered( StringRef name ); virtual void fatalErrorEncountered( StringRef name );
virtual bool isMulti() const;
// Listing support // Listing support
virtual void listReporters(std::vector<ReporterDescription> const& descriptions, Config const& config); virtual void listReporters(std::vector<ReporterDescription> const& descriptions, Config const& config);
virtual void listTests(std::vector<TestCaseHandle> const& tests, Config const& config); virtual void listTests(std::vector<TestCaseHandle> const& tests, Config const& config);

4
src/catch2/reporters/catch_reporter_listening.cpp
View File

@ -150,10 +150,6 @@ namespace Catch {
m_reporter->skipTest( testInfo ); m_reporter->skipTest( testInfo );
} }
bool ListeningReporter::isMulti() const {
return true;
}
void ListeningReporter::listReporters(std::vector<ReporterDescription> const& descriptions, Config const& config) { void ListeningReporter::listReporters(std::vector<ReporterDescription> const& descriptions, Config const& config) {
for (auto const& listener : m_listeners) { for (auto const& listener : m_listeners) {
listener->listReporters(descriptions, config); listener->listReporters(descriptions, config);

1
src/catch2/reporters/catch_reporter_listening.h
View File

@ -50,7 +50,6 @@ namespace Catch {
void testRunEnded( TestRunStats const& testRunStats ) override; void testRunEnded( TestRunStats const& testRunStats ) override;
void skipTest( TestCaseInfo const& testInfo ) override; void skipTest( TestCaseInfo const& testInfo ) override;
bool isMulti() const override;
void listReporters(std::vector<ReporterDescription> const& descriptions, Config const& config) override; void listReporters(std::vector<ReporterDescription> const& descriptions, Config const& config) override;
void listTests(std::vector<TestCaseHandle> const& tests, Config const& config) override; void listTests(std::vector<TestCaseHandle> const& tests, Config const& config) override;