Got rid of some warnings

This commit is contained in:
Phil Nash
2012-08-27 21:48:15 +01:00
parent ecf934b045
commit 78c92e68aa
3 changed files with 27 additions and 9 deletions

View File

@@ -317,7 +317,7 @@ namespace Catch {
return "!TBD";
}
virtual void parseIntoConfig( const Command& cmd, ConfigData& config ) {
virtual void parseIntoConfig( const Command&, ConfigData& config ) {
config.includeWhichResults = Include::SuccessfulResults;
}
};
@@ -335,7 +335,7 @@ namespace Catch {
return "!TBD";
}
virtual void parseIntoConfig( const Command& cmd, ConfigData& config ) {
virtual void parseIntoConfig( const Command&, ConfigData& config ) {
config.shouldDebugBreak = true;
}
};
@@ -397,7 +397,7 @@ namespace Catch {
return "!TBD";
}
virtual void parseIntoConfig( const Command& cmd, ConfigData& config ) {
virtual void parseIntoConfig( const Command&, ConfigData& config ) {
config.allowThrows = false;
}
};

View File

@@ -50,6 +50,11 @@ namespace Catch {
}
private:
#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunreachable-code"
#endif
bool isMatch( const TestCaseInfo& testCase ) const {
const std::string& name = testCase.getName();
@@ -63,9 +68,13 @@ namespace Catch {
case WildcardAtBothEnds:
return contains( name, m_stringToMatch );
}
throw std::logic_error( "Unhandled wildcard type" );
}
#ifdef __clang__
#pragma clang diagnostic pop
#endif
std::string m_stringToMatch;
IfFilterMatches::DoWhat m_filterType;
WildcardPosition m_wildcardPosition;