3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2025-08-25 07:55:40 +02:00
Code Issues Packages Projects Releases Wiki Activity

Forbid deducing reference types for m_predicate in FilterGenerator (#3005)

Browse Source 
Forbid deducing reference types for m_predicate in FilterGenerator to prevent dangling references.
This is needed for out-of-line predicates to work correctly instead of undefined behavior or crashes.

---------

Co-authored-by: Tek Mate <mate.tek@evosoft.com>
This commit is contained in:
Szapi
2025-08-23 21:55:38 +02:00
committed by GitHub
parent 582200a1f8
commit 85c4bad86b
15 changed files with 187 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/SelfTest/IntrospectiveTests/GeneratorsImpl.tests.cpp
View File

@@ -85,6 +85,19 @@ TEST_CASE("Generators internals", "[generators][internals]") {
filter([](int) { return false; }, values({ 1, 2, 3 })),
Catch::GeneratorException);
}
// Non-trivial usage
SECTION("Out-of-line predicates are copied into the generator") {
auto evilNumber = Catch::Detail::make_unique<int>(2);
auto gen = [&]{
const auto predicate = [&](int i) { return i != *evilNumber; };
return filter(predicate, values({ 2, 1, 2, 3, 2, 2 }));
}();
REQUIRE(gen.get() == 1);
REQUIRE(gen.next());
REQUIRE(gen.get() == 3);
REQUIRE_FALSE(gen.next());
}
}
SECTION("Take generator") {
SECTION("Take less") {