From 875299cff05560f186eb34e26f7576da61cba65e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Ho=C5=99e=C5=88ovsk=C3=BD?= Date: Fri, 7 Jan 2022 10:34:15 +0100 Subject: [PATCH] Remove unused member from Totals At one point it was inserted there as the simplest way to smuggle around an extra return value for specific errors in executing tests. Since then, the error has been changed to be handled differently, and the member became unused. --- src/catch2/catch_session.cpp | 2 +- src/catch2/catch_totals.hpp | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/catch2/catch_session.cpp b/src/catch2/catch_session.cpp index 5671e831..54b119b0 100644 --- a/src/catch2/catch_session.cpp +++ b/src/catch2/catch_session.cpp @@ -330,7 +330,7 @@ namespace Catch { // Note that on unices only the lower 8 bits are usually used, clamping // the return value to 255 prevents false negative when some multiple // of 256 tests has failed - return (std::min) (MaxExitCode, (std::max) (totals.error, static_cast(totals.assertions.failed))); + return (std::min) (MaxExitCode, static_cast(totals.assertions.failed)); } #if !defined(CATCH_CONFIG_DISABLE_EXCEPTIONS) catch( std::exception& ex ) { diff --git a/src/catch2/catch_totals.hpp b/src/catch2/catch_totals.hpp index a062319c..7ab6a1b6 100644 --- a/src/catch2/catch_totals.hpp +++ b/src/catch2/catch_totals.hpp @@ -33,7 +33,6 @@ namespace Catch { Totals delta( Totals const& prevTotals ) const; - int error = 0; Counts assertions; Counts testCases; };