Update catch_reporter_tap.hpp

TAP format requires all results to be reported.
Removed extraneous preferences function (handled by parent)
Incorporated fix from 3d9e7db2e0
Simplified total printing

src/catch2/reporters/catch_reporter_tap.cpp

@@ -209,10 +209,9 @@ namespace Catch {
     }
 
     void TAPReporter::testRunEnded(TestRunStats const& _testRunStats) {
+        stream << "1.." << _testRunStats.totals.assertions.total();
         if (_testRunStats.totals.testCases.total() == 0) {
-            stream << "1..0 # Skipped: No tests ran.";
-        } else {
-            stream << "1.." << counter;
+            stream << " # Skipped: No tests ran.";
         }
         stream << "\n\n" << std::flush;
         StreamingReporterBase::testRunEnded(_testRunStats);

src/catch2/reporters/catch_reporter_tap.hpp

@@ -11,8 +11,10 @@ namespace Catch {
 
     struct TAPReporter : StreamingReporterBase {
 
-        using StreamingReporterBase::StreamingReporterBase;
-
+        TAPReporter( ReporterConfig const& config ):
+            StreamingReporterBase( config ) {
+            m_reporterPrefs.shouldReportAllAssertions = true;
+        }
         ~TAPReporter() override;
 
         static std::string getDescription() {
@@ -20,10 +22,6 @@ namespace Catch {
             return "Reports test results in TAP format, suitable for test harnesses"s;
         }
 
-        ReporterPreferences getPreferences() const override {
-            return m_reporterPrefs;
-        }
-
         void noMatchingTestCases(std::string const& spec) override;
 
         void assertionStarting( AssertionInfo const& ) override {}

tests/SelfTest/Baselines/tap.sw.approved.txt

@@ -3992,5 +3992,5 @@ ok {test-number} - q3 == 23. for: 23.0 == 23.0
 ok {test-number} -
 # xmlentitycheck
 ok {test-number} -
-1..1992
+1..2000