From 8a2ff209826a9b2f52535577c1567b26e28dfd1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Ho=C5=99e=C5=88ovsk=C3=BD?= Date: Mon, 31 Jul 2017 12:28:13 +0200 Subject: [PATCH] Address some of the Resharper finds for Catch 1 Closes #957 as the other findings are mostly noise that is pointless to fix in a branch that will be soon EoLd. --- include/internal/catch_assertionresult.h | 2 +- include/internal/catch_assertionresult.hpp | 2 ++ include/internal/catch_test_spec_parser.hpp | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/internal/catch_assertionresult.h b/include/internal/catch_assertionresult.h index 5d6c86d1..39958498 100644 --- a/include/internal/catch_assertionresult.h +++ b/include/internal/catch_assertionresult.h @@ -39,7 +39,7 @@ namespace Catch { struct AssertionInfo { - AssertionInfo() {} + AssertionInfo(); AssertionInfo( char const * _macroName, SourceLineInfo const& _lineInfo, char const * _capturedExpression, diff --git a/include/internal/catch_assertionresult.hpp b/include/internal/catch_assertionresult.hpp index 2fa3373d..9a9fce63 100644 --- a/include/internal/catch_assertionresult.hpp +++ b/include/internal/catch_assertionresult.hpp @@ -13,6 +13,8 @@ namespace Catch { + AssertionInfo::AssertionInfo():macroName(""), capturedExpression(""), resultDisposition(ResultDisposition::Flags::Normal), secondArg(""){} + AssertionInfo::AssertionInfo( char const * _macroName, SourceLineInfo const& _lineInfo, char const * _capturedExpression, diff --git a/include/internal/catch_test_spec_parser.hpp b/include/internal/catch_test_spec_parser.hpp index 05bdcf4c..055bf1dc 100644 --- a/include/internal/catch_test_spec_parser.hpp +++ b/include/internal/catch_test_spec_parser.hpp @@ -30,7 +30,7 @@ namespace Catch { ITagAliasRegistry const* m_tagAliases; public: - TestSpecParser( ITagAliasRegistry const& tagAliases ) : m_tagAliases( &tagAliases ) {} + TestSpecParser( ITagAliasRegistry const& tagAliases ) :m_mode(None), m_exclusion(false), m_start(0), m_pos(0), m_tagAliases( &tagAliases ) {} TestSpecParser& parse( std::string const& arg ) { m_mode = None;