mirror of
https://github.com/catchorg/Catch2.git
synced 2025-11-03 05:29:32 +01:00
Fix bad indentation calculation in the console reporter
The problem came from the console reporter trying to provide a
fancy linebreaking (primarily for things like `SCENARIO` or the
BDD macros), so that new lines start with extra indentation if
the text being line broken starts as "{text}: ".
The console reporter did not properly take into account cases
where the ": " part would already be in a later line, in which
case it would ask for non-sensical level of indentation (larger
than single line length).
We fixed this by also enforcing that the special indentation case
only triggers if the ": " is found early enough in the line, so
that we also avoid degenerate cases like this:
```
blablabla: F
a
n
c
y
.
.
.
```
Fixes #2309
This commit is contained in:
@@ -181,6 +181,7 @@
|
||||
<testCase name="Reporter's write listings to provided stream/xml reporter lists tags" duration="{duration}"/>
|
||||
<testCase name="Reporter's write listings to provided stream/xml reporter lists reporters" duration="{duration}"/>
|
||||
<testCase name="Reporter's write listings to provided stream/xml reporter lists tests" duration="{duration}"/>
|
||||
<testCase name="Reproducer for #2309 - a very long description past 80 chars (default console width) with a late colon : blablabla" duration="{duration}"/>
|
||||
<testCase name="The default listing implementation write to provided stream/Listing tags" duration="{duration}"/>
|
||||
<testCase name="The default listing implementation write to provided stream/Listing reporters" duration="{duration}"/>
|
||||
<testCase name="The default listing implementation write to provided stream/Listing tests" duration="{duration}"/>
|
||||
|
||||
Reference in New Issue
Block a user