3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2024-11-29 16:53:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

RandomNumberGenerator::result_type should be unsigned (#1050)

Browse Source 
`result_type` must be unsigned:
http://en.cppreference.com/w/cpp/concept/UniformRandomBitGenerator

Using a signed type causes an infinite loop working with MS Visual Studio 2017, targetting: v140, WindowsTargetPlatformVersion 10.0.15063.0, Debug, x64
This commit is contained in:
Sebastian Grottel 2017-10-15 18:30:40 +02:00 committed by Martin Hořeňovský
parent e68485e196
commit 96c5de678d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/internal/catch_random_number_generator.h
View File

@ -20,7 +20,7 @@ namespace Catch {
unsigned int rngSeed(); unsigned int rngSeed();
struct RandomNumberGenerator { struct RandomNumberGenerator {
using result_type = std::ptrdiff_t; using result_type = unsigned int;
static constexpr result_type (min)() { return 0; } static constexpr result_type (min)() { return 0; }
static constexpr result_type (max)() { return 1000000; } static constexpr result_type (max)() { return 1000000; }