Approval tests can use Catch path fixed in env. var, and convert nullptr and __null to 0 for comparison

This commit is contained in:
Phil Nash
2017-01-09 14:12:12 +00:00
parent 37e1e24309
commit 976a655496
5 changed files with 158 additions and 140 deletions

View File

@@ -923,7 +923,7 @@ MiscTests.cpp:<line number>
MiscTests.cpp:<line number>:
PASSED:
REQUIRE_THAT( "", Equals(nullptr) )
REQUIRE_THAT( "", Equals(0) )
with expansion:
"" equals: ""
@@ -5446,9 +5446,9 @@ ConditionTests.cpp:<line number>
ConditionTests.cpp:<line number>:
PASSED:
REQUIRE( p == nullptr )
REQUIRE( p == 0 )
with expansion:
NULL == nullptr
NULL == 0
ConditionTests.cpp:<line number>:
PASSED:
@@ -5458,39 +5458,39 @@ with expansion:
ConditionTests.cpp:<line number>:
PASSED:
REQUIRE( p != nullptr )
REQUIRE( p != 0 )
with expansion:
0x<hex digits> != nullptr
0x<hex digits> != 0
ConditionTests.cpp:<line number>:
PASSED:
REQUIRE( cp != nullptr )
REQUIRE( cp != 0 )
with expansion:
0x<hex digits> != nullptr
0x<hex digits> != 0
ConditionTests.cpp:<line number>:
PASSED:
REQUIRE( cpc != nullptr )
REQUIRE( cpc != 0 )
with expansion:
0x<hex digits> != nullptr
0x<hex digits> != 0
ConditionTests.cpp:<line number>:
PASSED:
REQUIRE( returnsNull() == nullptr )
REQUIRE( returnsNull() == 0 )
with expansion:
{null string} == nullptr
{null string} == 0
ConditionTests.cpp:<line number>:
PASSED:
REQUIRE( returnsConstNull() == nullptr )
REQUIRE( returnsConstNull() == 0 )
with expansion:
{null string} == nullptr
{null string} == 0
ConditionTests.cpp:<line number>:
PASSED:
REQUIRE( nullptr != p )
REQUIRE( 0 != p )
with expansion:
nullptr != 0x<hex digits>
0 != 0x<hex digits>
-------------------------------------------------------------------------------
Pointers can be converted to strings
@@ -7886,9 +7886,9 @@ TrickyTests.cpp:<line number>
TrickyTests.cpp:<line number>:
PASSED:
REQUIRE( obj.prop != nullptr )
REQUIRE( obj.prop != 0 )
with expansion:
0x<hex digits> != nullptr
0x<hex digits> != 0
-------------------------------------------------------------------------------
checkedElse
@@ -8253,13 +8253,13 @@ MiscTests.cpp:<line number>
MiscTests.cpp:<line number>:
PASSED:
REQUIRE( makeString( false ) != static_cast<char*>(nullptr) )
REQUIRE( makeString( false ) != static_cast<char*>(0) )
with expansion:
"valid string" != {null string}
MiscTests.cpp:<line number>:
PASSED:
REQUIRE( makeString( true ) == static_cast<char*>(nullptr) )
REQUIRE( makeString( true ) == static_cast<char*>(0) )
with expansion:
{null string} == {null string}
@@ -8271,9 +8271,9 @@ TrickyTests.cpp:<line number>
TrickyTests.cpp:<line number>:
PASSED:
REQUIRE( ptr.get() == nullptr )
REQUIRE( ptr.get() == 0 )
with expansion:
NULL == nullptr
NULL == 0
-------------------------------------------------------------------------------
pair<pair<int,const char *,pair<std::string,int> > -> toString
@@ -8797,18 +8797,18 @@ with expansion:
"{ 0 }" == "{ 0 }"
-------------------------------------------------------------------------------
tuple<nullptr,int,const char *>
tuple<0,int,const char *>
-------------------------------------------------------------------------------
ToStringTuple.cpp:<line number>
...............................................................................
ToStringTuple.cpp:<line number>:
PASSED:
CHECK( "{ nullptr, 42, \"Catch me\" }" == Catch::toString(value) )
CHECK( "{ 0, 42, \"Catch me\" }" == Catch::toString(value) )
with expansion:
"{ nullptr, 42, "Catch me" }"
"{ 0, 42, "Catch me" }"
==
"{ nullptr, 42, "Catch me" }"
"{ 0, 42, "Catch me" }"
-------------------------------------------------------------------------------
tuple<string,string>

View File

@@ -661,7 +661,7 @@ TrickyTests.cpp:<line number>
<testcase classname="global" name="tuple&lt;>" time="{duration}"/>
<testcase classname="global" name="tuple&lt;float,int>" time="{duration}"/>
<testcase classname="global" name="tuple&lt;int>" time="{duration}"/>
<testcase classname="global" name="tuple&lt;nullptr,int,const char *>" time="{duration}"/>
<testcase classname="global" name="tuple&lt;0,int,const char *>" time="{duration}"/>
<testcase classname="global" name="tuple&lt;string,string>" time="{duration}"/>
<testcase classname="global" name="tuple&lt;tuple&lt;int>,tuple&lt;>,float>" time="{duration}"/>
<testcase classname="global" name="vec&lt;vec&lt;string,alloc>> -> toString" time="{duration}"/>

View File

@@ -1015,7 +1015,7 @@
<TestCase name="Equals string matcher, with NULL">
<Expression success="true" type="REQUIRE_THAT" filename="projects/SelfTest/MiscTests.cpp" >
<Original>
"", Equals(nullptr)
"", Equals(0)
</Original>
<Expanded>
"" equals: ""
@@ -5709,10 +5709,10 @@ four"
<TestCase name="Pointers can be compared to null">
<Expression success="true" type="REQUIRE" filename="projects/SelfTest/ConditionTests.cpp" >
<Original>
p == nullptr
p == 0
</Original>
<Expanded>
NULL == nullptr
NULL == 0
</Expanded>
</Expression>
<Expression success="true" type="REQUIRE" filename="projects/SelfTest/ConditionTests.cpp" >
@@ -5725,50 +5725,50 @@ four"
</Expression>
<Expression success="true" type="REQUIRE" filename="projects/SelfTest/ConditionTests.cpp" >
<Original>
p != nullptr
p != 0
</Original>
<Expanded>
0x<hex digits> != nullptr
0x<hex digits> != 0
</Expanded>
</Expression>
<Expression success="true" type="REQUIRE" filename="projects/SelfTest/ConditionTests.cpp" >
<Original>
cp != nullptr
cp != 0
</Original>
<Expanded>
0x<hex digits> != nullptr
0x<hex digits> != 0
</Expanded>
</Expression>
<Expression success="true" type="REQUIRE" filename="projects/SelfTest/ConditionTests.cpp" >
<Original>
cpc != nullptr
cpc != 0
</Original>
<Expanded>
0x<hex digits> != nullptr
0x<hex digits> != 0
</Expanded>
</Expression>
<Expression success="true" type="REQUIRE" filename="projects/SelfTest/ConditionTests.cpp" >
<Original>
returnsNull() == nullptr
returnsNull() == 0
</Original>
<Expanded>
{null string} == nullptr
{null string} == 0
</Expanded>
</Expression>
<Expression success="true" type="REQUIRE" filename="projects/SelfTest/ConditionTests.cpp" >
<Original>
returnsConstNull() == nullptr
returnsConstNull() == 0
</Original>
<Expanded>
{null string} == nullptr
{null string} == 0
</Expanded>
</Expression>
<Expression success="true" type="REQUIRE" filename="projects/SelfTest/ConditionTests.cpp" >
<Original>
nullptr != p
0 != p
</Original>
<Expanded>
nullptr != 0x<hex digits>
0 != 0x<hex digits>
</Expanded>
</Expression>
<OverallResult success="true"/>
@@ -8318,10 +8318,10 @@ there"
<TestCase name="boolean member">
<Expression success="true" type="REQUIRE" filename="projects/SelfTest/TrickyTests.cpp" >
<Original>
obj.prop != nullptr
obj.prop != 0
</Original>
<Expanded>
0x<hex digits> != nullptr
0x<hex digits> != 0
</Expanded>
</Expression>
<OverallResult success="true"/>
@@ -8709,7 +8709,7 @@ there"
<TestCase name="null strings">
<Expression success="true" type="REQUIRE" filename="projects/SelfTest/MiscTests.cpp" >
<Original>
makeString( false ) != static_cast&lt;char*>(nullptr)
makeString( false ) != static_cast&lt;char*>(0)
</Original>
<Expanded>
"valid string" != {null string}
@@ -8717,7 +8717,7 @@ there"
</Expression>
<Expression success="true" type="REQUIRE" filename="projects/SelfTest/MiscTests.cpp" >
<Original>
makeString( true ) == static_cast&lt;char*>(nullptr)
makeString( true ) == static_cast&lt;char*>(0)
</Original>
<Expanded>
{null string} == {null string}
@@ -8728,10 +8728,10 @@ there"
<TestCase name="null_ptr">
<Expression success="true" type="REQUIRE" filename="projects/SelfTest/TrickyTests.cpp" >
<Original>
ptr.get() == nullptr
ptr.get() == 0
</Original>
<Expanded>
NULL == nullptr
NULL == 0
</Expanded>
</Expression>
<OverallResult success="true"/>
@@ -9264,15 +9264,15 @@ there"
</Expression>
<OverallResult success="true"/>
</TestCase>
<TestCase name="tuple&lt;nullptr,int,const char *>">
<TestCase name="tuple&lt;0,int,const char *>">
<Expression success="true" type="CHECK" filename="projects/SelfTest/ToStringTuple.cpp" >
<Original>
"{ nullptr, 42, \"Catch me\" }" == Catch::toString(value)
"{ 0, 42, \"Catch me\" }" == Catch::toString(value)
</Original>
<Expanded>
"{ nullptr, 42, "Catch me" }"
"{ 0, 42, "Catch me" }"
==
"{ nullptr, 42, "Catch me" }"
"{ 0, 42, "Catch me" }"
</Expanded>
</Expression>
<OverallResult success="true"/>