From 97d0b1e00ed198eb74351874aa8b42423b93c67a Mon Sep 17 00:00:00 2001 From: Rutayan Patro <59845040+rutayan@users.noreply.github.com> Date: Mon, 26 Sep 2022 12:07:50 -0400 Subject: [PATCH] Suppress clang-tidy warnings for TEMPLATE_TEST_CASE (#2536) * Suppress clang-tidy *-avoid-c-arrays for TEMPLATE_TEST_CASE * Made globalRegistrar `const` to avoid `cppcoreguidelines-avoid-non-const-global-variables` Fixes #2095 --- src/catch2/internal/catch_template_test_registry.hpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/catch2/internal/catch_template_test_registry.hpp b/src/catch2/internal/catch_template_test_registry.hpp index bfac3bc8..dfc80726 100644 --- a/src/catch2/internal/catch_template_test_registry.hpp +++ b/src/catch2/internal/catch_template_test_registry.hpp @@ -84,12 +84,12 @@ struct TestName{\ TestName(){\ size_t index = 0; \ - constexpr char const* tmpl_types[] = {CATCH_REC_LIST(INTERNAL_CATCH_STRINGIZE_WITHOUT_PARENS, __VA_ARGS__)};\ - using expander = size_t[];\ + constexpr char const* tmpl_types[] = {CATCH_REC_LIST(INTERNAL_CATCH_STRINGIZE_WITHOUT_PARENS, __VA_ARGS__)}; /* NOLINT(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays,hicpp-avoid-c-arrays) */\ + using expander = size_t[]; /* NOLINT(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays,hicpp-avoid-c-arrays) */\ (void)expander{(reg_test(Types{}, Catch::NameAndTags{ Name " - " + std::string(tmpl_types[index]), Tags } ), index++)... };/* NOLINT */ \ }\ };\ - static int INTERNAL_CATCH_UNIQUE_NAME( globalRegistrar ) = [](){\ + static const int INTERNAL_CATCH_UNIQUE_NAME( globalRegistrar ) = [](){\ TestName();\ return 0;\ }();\