Upgrade to C++17

tests/SelfTest/Baselines/console.sw.approved.txt

@@ -159,7 +159,7 @@ Compilation.tests.cpp:<line number>
 ...............................................................................
 
 Compilation.tests.cpp:<line number>: PASSED:
-  REQUIRE( std::is_same<TypeList<int>, TypeList<int>>::value )
+  REQUIRE( std::is_same_v<TypeList<int>, TypeList<int>> )
 with expansion:
   true
 
@@ -3274,8 +3274,8 @@ Matchers.tests.cpp:<line number>
 
 Matchers.tests.cpp:<line number>: PASSED:
 with message:
-  std::is_same< decltype( ( MatcherA() && MatcherB() ) && MatcherC() ), Catch::
-  Matchers::Detail:: MatchAllOfGeneric<MatcherA, MatcherB, MatcherC>>::value
+  std::is_same_v< decltype( ( MatcherA() && MatcherB() ) && MatcherC() ),
+  Catch::Matchers::Detail:: MatchAllOfGeneric<MatcherA, MatcherB, MatcherC>>
 
 Matchers.tests.cpp:<line number>: PASSED:
   REQUIRE_THAT( 1, ( MatcherA() && MatcherB() ) && MatcherC() )
@@ -3285,8 +3285,8 @@ with expansion:
 
 Matchers.tests.cpp:<line number>: PASSED:
 with message:
-  std::is_same< decltype( MatcherA() && ( MatcherB() && MatcherC() ) ), Catch::
-  Matchers::Detail:: MatchAllOfGeneric<MatcherA, MatcherB, MatcherC>>::value
+  std::is_same_v< decltype( MatcherA() && ( MatcherB() && MatcherC() ) ),
+  Catch::Matchers::Detail:: MatchAllOfGeneric<MatcherA, MatcherB, MatcherC>>
 
 Matchers.tests.cpp:<line number>: PASSED:
   REQUIRE_THAT( 1, MatcherA() && ( MatcherB() && MatcherC() ) )
@@ -3296,9 +3296,9 @@ with expansion:
 
 Matchers.tests.cpp:<line number>: PASSED:
 with message:
-  std::is_same< decltype( ( MatcherA() && MatcherB() ) && ( MatcherC() &&
+  std::is_same_v< decltype( ( MatcherA() && MatcherB() ) && ( MatcherC() &&
   MatcherD() ) ), Catch::Matchers::Detail:: MatchAllOfGeneric<MatcherA,
-  MatcherB, MatcherC, MatcherD>>:: value
+  MatcherB, MatcherC, MatcherD>>
 
 Matchers.tests.cpp:<line number>: PASSED:
   REQUIRE_THAT( 1, ( MatcherA() && MatcherB() ) && ( MatcherC() && MatcherD() ) )
@@ -3314,8 +3314,8 @@ Matchers.tests.cpp:<line number>
 
 Matchers.tests.cpp:<line number>: PASSED:
 with message:
-  std::is_same< decltype( ( MatcherA() || MatcherB() ) || MatcherC() ), Catch::
-  Matchers::Detail:: MatchAnyOfGeneric<MatcherA, MatcherB, MatcherC>>::value
+  std::is_same_v< decltype( ( MatcherA() || MatcherB() ) || MatcherC() ),
+  Catch::Matchers::Detail:: MatchAnyOfGeneric<MatcherA, MatcherB, MatcherC>>
 
 Matchers.tests.cpp:<line number>: PASSED:
   REQUIRE_THAT( 1, ( MatcherA() || MatcherB() ) || MatcherC() )
@@ -3325,8 +3325,8 @@ with expansion:
 
 Matchers.tests.cpp:<line number>: PASSED:
 with message:
-  std::is_same< decltype( MatcherA() || ( MatcherB() || MatcherC() ) ), Catch::
-  Matchers::Detail:: MatchAnyOfGeneric<MatcherA, MatcherB, MatcherC>>::value
+  std::is_same_v< decltype( MatcherA() || ( MatcherB() || MatcherC() ) ),
+  Catch::Matchers::Detail:: MatchAnyOfGeneric<MatcherA, MatcherB, MatcherC>>
 
 Matchers.tests.cpp:<line number>: PASSED:
   REQUIRE_THAT( 1, MatcherA() || ( MatcherB() || MatcherC() ) )
@@ -3336,9 +3336,9 @@ with expansion:
 
 Matchers.tests.cpp:<line number>: PASSED:
 with message:
-  std::is_same< decltype( ( MatcherA() || MatcherB() ) || ( MatcherC() ||
+  std::is_same_v< decltype( ( MatcherA() || MatcherB() ) || ( MatcherC() ||
   MatcherD() ) ), Catch::Matchers::Detail:: MatchAnyOfGeneric<MatcherA,
-  MatcherB, MatcherC, MatcherD>>:: value
+  MatcherB, MatcherC, MatcherD>>
 
 Matchers.tests.cpp:<line number>: PASSED:
   REQUIRE_THAT( 1, ( MatcherA() || MatcherB() ) || ( MatcherC() || MatcherD() ) )
@@ -3354,8 +3354,8 @@ Matchers.tests.cpp:<line number>
 
 Matchers.tests.cpp:<line number>: PASSED:
 with message:
-  std::is_same< decltype( !MatcherA() ), Catch::Matchers::Detail::
-  MatchNotOfGeneric<MatcherA>>::value
+  std::is_same_v< decltype( !MatcherA() ), Catch::Matchers::Detail::
+  MatchNotOfGeneric<MatcherA>>
 
 Matchers.tests.cpp:<line number>: PASSED:
   REQUIRE_THAT( 0, !MatcherA() )
@@ -3364,7 +3364,7 @@ with expansion:
 
 Matchers.tests.cpp:<line number>: PASSED:
 with message:
-  std::is_same<decltype( !!MatcherA() ), MatcherA const&>::value
+  std::is_same_v<decltype( !!MatcherA() ), MatcherA const&>
 
 Matchers.tests.cpp:<line number>: PASSED:
   REQUIRE_THAT( 1, !!MatcherA() )
@@ -3373,8 +3373,8 @@ with expansion:
 
 Matchers.tests.cpp:<line number>: PASSED:
 with message:
-  std::is_same< decltype( !!!MatcherA() ), Catch::Matchers::Detail::
-  MatchNotOfGeneric<MatcherA>>::value
+  std::is_same_v< decltype( !!!MatcherA() ), Catch::Matchers::Detail::
+  MatchNotOfGeneric<MatcherA>>
 
 Matchers.tests.cpp:<line number>: PASSED:
   REQUIRE_THAT( 0, !!!MatcherA() )
@@ -3383,7 +3383,7 @@ with expansion:
 
 Matchers.tests.cpp:<line number>: PASSED:
 with message:
-  std::is_same<decltype( !!!!MatcherA() ), MatcherA const&>::value
+  std::is_same_v<decltype( !!!!MatcherA() ), MatcherA const&>
 
 Matchers.tests.cpp:<line number>: PASSED:
   REQUIRE_THAT( 1, !!!!MatcherA() )
@@ -3398,9 +3398,9 @@ Matchers.tests.cpp:<line number>
 
 Matchers.tests.cpp:<line number>: PASSED:
 with message:
-  std::is_same<decltype( StartsWith( "foo" ) || ( StartsWith( "bar" ) &&
+  std::is_same_v<decltype( StartsWith( "foo" ) || ( StartsWith( "bar" ) &&
   EndsWith( "bar" ) && !EndsWith( "foo" ) ) ), Catch::Matchers::Detail::
-  MatchAnyOf<std::string>>::value
+  MatchAnyOf<std::string>>
 
 -------------------------------------------------------------------------------
 Combining only templated matchers
@@ -3410,8 +3410,8 @@ Matchers.tests.cpp:<line number>
 
 Matchers.tests.cpp:<line number>: PASSED:
 with message:
-  std::is_same<decltype( MatcherA() || MatcherB() ), Catch::Matchers::Detail::
-  MatchAnyOfGeneric<MatcherA, MatcherB>>::value
+  std::is_same_v<decltype( MatcherA() || MatcherB() ), Catch::Matchers::Detail:
+  : MatchAnyOfGeneric<MatcherA, MatcherB>>
 
 Matchers.tests.cpp:<line number>: PASSED:
   REQUIRE_THAT( 1, MatcherA() || MatcherB() )
@@ -3420,8 +3420,8 @@ with expansion:
 
 Matchers.tests.cpp:<line number>: PASSED:
 with message:
-  std::is_same<decltype( MatcherA() && MatcherB() ), Catch::Matchers::Detail::
-  MatchAllOfGeneric<MatcherA, MatcherB>>::value
+  std::is_same_v<decltype( MatcherA() && MatcherB() ), Catch::Matchers::Detail:
+  : MatchAllOfGeneric<MatcherA, MatcherB>>
 
 Matchers.tests.cpp:<line number>: PASSED:
   REQUIRE_THAT( 1, MatcherA() && MatcherB() )
@@ -3430,9 +3430,9 @@ with expansion:
 
 Matchers.tests.cpp:<line number>: PASSED:
 with message:
-  std::is_same< decltype( MatcherA() || !MatcherB() ), Catch::Matchers::Detail:
-  :MatchAnyOfGeneric< MatcherA, Catch::Matchers::Detail::MatchNotOfGeneric
-  <MatcherB>>>::value
+  std::is_same_v< decltype( MatcherA() || !MatcherB() ), Catch::Matchers::
+  Detail::MatchAnyOfGeneric< MatcherA, Catch::Matchers::Detail::
+  MatchNotOfGeneric<MatcherB>>>
 
 Matchers.tests.cpp:<line number>: PASSED:
   REQUIRE_THAT( 1, MatcherA() || !MatcherB() )
@@ -8475,19 +8475,19 @@ Compilation.tests.cpp:<line number>
 
 Compilation.tests.cpp:<line number>: PASSED:
 with message:
-  std::is_void<void>::value
+  std::is_void_v<void>
 
 Compilation.tests.cpp:<line number>: PASSED:
 with message:
-  !(std::is_void<int>::value)
+  !(std::is_void_v<int>)
 
 Compilation.tests.cpp:<line number>: PASSED:
 with message:
-  std::is_void<void>::value
+  std::is_void_v<void>
 
 Compilation.tests.cpp:<line number>: PASSED:
 with message:
-  !(std::is_void<int>::value)
+  !(std::is_void_v<int>)
 
 -------------------------------------------------------------------------------
 Ordering comparison checks that should fail
@@ -10052,7 +10052,7 @@ Misc.tests.cpp:<line number>
 ...............................................................................
 
 Misc.tests.cpp:<line number>: PASSED:
-  REQUIRE( std::tuple_size<TestType>::value >= 1 )
+  REQUIRE( std::tuple_size_v<TestType> >= 1 )
 with expansion:
   3 >= 1
 
@@ -10063,7 +10063,7 @@ Misc.tests.cpp:<line number>
 ...............................................................................
 
 Misc.tests.cpp:<line number>: PASSED:
-  REQUIRE( std::tuple_size<TestType>::value >= 1 )
+  REQUIRE( std::tuple_size_v<TestType> >= 1 )
 with expansion:
   2 >= 1
 
@@ -10074,7 +10074,7 @@ Misc.tests.cpp:<line number>
 ...............................................................................
 
 Misc.tests.cpp:<line number>: PASSED:
-  REQUIRE( std::tuple_size<TestType>::value >= 1 )
+  REQUIRE( std::tuple_size_v<TestType> >= 1 )
 with expansion:
   1 >= 1
 
@@ -12106,7 +12106,7 @@ Misc.tests.cpp:<line number>
 ...............................................................................
 
 Misc.tests.cpp:<line number>: PASSED:
-  REQUIRE( std::is_default_constructible<TestType>::value )
+  REQUIRE( std::is_default_constructible_v<TestType> )
 with expansion:
   true
 
@@ -12118,7 +12118,7 @@ Misc.tests.cpp:<line number>
 ...............................................................................
 
 Misc.tests.cpp:<line number>: PASSED:
-  REQUIRE( std::is_default_constructible<TestType>::value )
+  REQUIRE( std::is_default_constructible_v<TestType> )
 with expansion:
   true
 
@@ -12130,7 +12130,7 @@ Misc.tests.cpp:<line number>
 ...............................................................................
 
 Misc.tests.cpp:<line number>: PASSED:
-  REQUIRE( std::is_trivially_copyable<TestType>::value )
+  REQUIRE( std::is_trivially_copyable_v<TestType> )
 with expansion:
   true
 
@@ -12142,7 +12142,7 @@ Misc.tests.cpp:<line number>
 ...............................................................................
 
 Misc.tests.cpp:<line number>: PASSED:
-  REQUIRE( std::is_trivially_copyable<TestType>::value )
+  REQUIRE( std::is_trivially_copyable_v<TestType> )
 with expansion:
   true
 
@@ -12153,7 +12153,7 @@ Misc.tests.cpp:<line number>
 ...............................................................................
 
 Misc.tests.cpp:<line number>: PASSED:
-  REQUIRE( std::is_arithmetic<TestType>::value )
+  REQUIRE( std::is_arithmetic_v<TestType> )
 with expansion:
   true
 
@@ -12164,7 +12164,7 @@ Misc.tests.cpp:<line number>
 ...............................................................................
 
 Misc.tests.cpp:<line number>: PASSED:
-  REQUIRE( std::is_arithmetic<TestType>::value )
+  REQUIRE( std::is_arithmetic_v<TestType> )
 with expansion:
   true
 
@@ -12175,7 +12175,7 @@ Misc.tests.cpp:<line number>
 ...............................................................................
 
 Misc.tests.cpp:<line number>: PASSED:
-  REQUIRE( std::is_arithmetic<TestType>::value )
+  REQUIRE( std::is_arithmetic_v<TestType> )
 with expansion:
   true