diff --git a/include/internal/catch_common.h b/include/internal/catch_common.h index 957ce257..5b091b0a 100644 --- a/include/internal/catch_common.h +++ b/include/internal/catch_common.h @@ -57,16 +57,6 @@ namespace Catch { delete it->second; } - template - inline void forEach( ContainerT& container, Function function ) { - std::for_each( container.begin(), container.end(), function ); - } - - template - inline void forEach( ContainerT const& container, Function function ) { - std::for_each( container.begin(), container.end(), function ); - } - bool startsWith( std::string const& s, std::string const& prefix ); bool endsWith( std::string const& s, std::string const& suffix ); bool contains( std::string const& s, std::string const& infix ); diff --git a/include/reporters/catch_reporter_xml.hpp b/include/reporters/catch_reporter_xml.hpp index 11ecd910..15aa828f 100644 --- a/include/reporters/catch_reporter_xml.hpp +++ b/include/reporters/catch_reporter_xml.hpp @@ -59,7 +59,7 @@ namespace Catch { virtual void StartSection( const std::string& sectionName, const std::string& description ) { if( m_sectionDepth++ > 0 ) { m_xml.startElement( "Section" ) - .writeAttribute( "name", sectionName ) + .writeAttribute( "name", trim( sectionName ) ) .writeAttribute( "description", description ); } } @@ -76,7 +76,7 @@ namespace Catch { } virtual void StartTestCase( const Catch::TestCaseInfo& testInfo ) { - m_xml.startElement( "TestCase" ).writeAttribute( "name", testInfo.name ); + m_xml.startElement( "TestCase" ).writeAttribute( "name", trim( testInfo.name ) ); m_currentTestSuccess = true; } diff --git a/projects/SelfTest/Baselines/xml.sw.approved.txt b/projects/SelfTest/Baselines/xml.sw.approved.txt index ded8c1f2..8b90d872 100644 --- a/projects/SelfTest/Baselines/xml.sw.approved.txt +++ b/projects/SelfTest/Baselines/xml.sw.approved.txt @@ -6671,18 +6671,18 @@ there" -
+
-
-
+
+
-
-
-
+
+
+
itDoesThis() @@ -6697,9 +6697,9 @@ there"
-
-
-
+
+
+
itDoesThis() @@ -6708,7 +6708,7 @@ there" true -
+
itDoesThat() @@ -6728,7 +6728,7 @@ there" -
+
v.size() == 0 @@ -6739,7 +6739,7 @@ there"
-
+
v.size() == 0 @@ -6748,12 +6748,12 @@ there" 0 == 0 -
+
-
+
v.size() == 0 @@ -6762,8 +6762,8 @@ there" 0 == 0 -
-
+
+
v.size() == 10 @@ -6786,7 +6786,7 @@ there"
-
+
v.size() == 0 @@ -6795,8 +6795,8 @@ there" 0 == 0 -
-
+
+
v.size() == 10 @@ -6822,7 +6822,7 @@ there"
-
+
v.size() == 0 @@ -6831,8 +6831,8 @@ there" 0 == 0 -
-
+
+
v.size() == 10 @@ -6850,7 +6850,7 @@ there"
-
+
v.size() == 5 @@ -6877,7 +6877,7 @@ there"
-
+
v.size() == 0 @@ -6886,12 +6886,12 @@ there" 0 == 0 -
+
-
+
v.size() == 0 @@ -6900,8 +6900,8 @@ there" 0 == 0 -
-
+
+
v.capacity() >= 10 @@ -6927,18 +6927,18 @@ there" -
+
-
-
+
+
-
-
-
+
+
+