Builds almost completely cleanly with -WEverything in LLVM

include/reporters/catch_reporter_basic.hpp

@@ -35,7 +35,7 @@ namespace Catch {
     class BasicReporter : public SharedImpl<IReporter> {
     
         struct SpanInfo {
-        
+
             SpanInfo() 
             :   emitted( false )
             {}
@@ -60,6 +60,8 @@ namespace Catch {
             m_firstSectionInTestCase( true ),
             m_aborted( false )
         {}
+
+        virtual ~BasicReporter();
         
         static std::string getDescription() {
             return "Reports test results as lines of text";
@@ -222,7 +224,6 @@ namespace Catch {
                 case ResultWas::FailureBit:
                 case ResultWas::ExpressionFailed:
                 case ResultWas::Exception:
-                default:
                     if( !resultInfo.hasExpression() ) {
                         if( resultInfo.ok() ) {
                             TextColour colour( TextColour::Success );

include/reporters/catch_reporter_junit.hpp

@@ -61,7 +61,8 @@ namespace Catch {
         :   m_config( config ),
             m_testSuiteStats( "AllTests" ),
             m_currentStats( &m_testSuiteStats )
-        {}        
+        {}
+        virtual ~JunitReporter();
         
         static std::string getDescription() {
             return "Reports test results in an XML format that looks like Ant's junitreport target";
@@ -131,8 +132,6 @@ namespace Catch {
                     case ResultWas::FailureBit:
                     case ResultWas::Exception:
                     case ResultWas::DidntThrowException:
-                    default:
-                        stats.m_element = "unknown";
                         break;
                 }
                 testCaseStats.m_testStats.push_back( stats );                

include/reporters/catch_reporter_xml.hpp

@@ -21,6 +21,7 @@ namespace Catch {
         static std::string getDescription() {
             return "Reports test results as an XML document";
         }
+        virtual ~XmlReporter();
         
     private: // IReporter
 
@@ -116,7 +117,6 @@ namespace Catch {
                 case ResultWas::ExpressionFailed:
                 case ResultWas::Exception:
                 case ResultWas::DidntThrowException:
-                default:
                     break;
             }            
             if( resultInfo.hasExpression() )