From bfe5553416609372655e76bc8849d2c6ce4c2705 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Ho=C5=99e=C5=88ovsk=C3=BD?= Date: Thu, 26 Nov 2020 10:21:12 +0100 Subject: [PATCH] CumulativeReporterBase doesn't use shared_ptrs for sectionStack --- src/catch2/reporters/catch_reporter_cumulative_base.cpp | 2 +- src/catch2/reporters/catch_reporter_cumulative_base.hpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/catch2/reporters/catch_reporter_cumulative_base.cpp b/src/catch2/reporters/catch_reporter_cumulative_base.cpp index 67154d95..5a25ab9b 100644 --- a/src/catch2/reporters/catch_reporter_cumulative_base.cpp +++ b/src/catch2/reporters/catch_reporter_cumulative_base.cpp @@ -57,7 +57,7 @@ namespace Catch { } m_deepestSection = node.get(); - m_sectionStack.push_back( std::move(node) ); + m_sectionStack.push_back( node.get() ); } bool CumulativeReporterBase::assertionEnded( diff --git a/src/catch2/reporters/catch_reporter_cumulative_base.hpp b/src/catch2/reporters/catch_reporter_cumulative_base.hpp index 94b4c589..7f228420 100644 --- a/src/catch2/reporters/catch_reporter_cumulative_base.hpp +++ b/src/catch2/reporters/catch_reporter_cumulative_base.hpp @@ -80,7 +80,7 @@ namespace Catch { std::shared_ptr m_rootSection; SectionNode* m_deepestSection = nullptr; - std::vector> m_sectionStack; + std::vector m_sectionStack; }; } // end namespace Catch