mirror of
https://github.com/catchorg/Catch2.git
synced 2024-12-23 03:43:28 +01:00
Fixed inconsistent and trailing whitespace
This means that all tabs used in indentation are now 4 spaces and that there should be no more trailing whitespace. Ill also look into creating a pre-commit hook that will prevent this from happening in the future. Fixes #105
This commit is contained in:
parent
60a9ac7e65
commit
c390c4cb9f
@ -65,7 +65,7 @@ namespace Catch {
|
|||||||
}
|
}
|
||||||
inline void setUseColour( ConfigData& config, std::string const& value ) {
|
inline void setUseColour( ConfigData& config, std::string const& value ) {
|
||||||
std::string mode = toLower( value );
|
std::string mode = toLower( value );
|
||||||
|
|
||||||
if( mode == "yes" )
|
if( mode == "yes" )
|
||||||
config.useColour = UseColour::Yes;
|
config.useColour = UseColour::Yes;
|
||||||
else if( mode == "no" )
|
else if( mode == "no" )
|
||||||
@ -201,7 +201,7 @@ namespace Catch {
|
|||||||
cli["--force-colour"]
|
cli["--force-colour"]
|
||||||
.describe( "force colourised output (deprecated)" )
|
.describe( "force colourised output (deprecated)" )
|
||||||
.bind( &forceColour );
|
.bind( &forceColour );
|
||||||
|
|
||||||
cli["--use-colour"]
|
cli["--use-colour"]
|
||||||
.describe( "should output be colourised" )
|
.describe( "should output be colourised" )
|
||||||
.bind( &setUseColour, "yes|no" );
|
.bind( &setUseColour, "yes|no" );
|
||||||
|
@ -111,7 +111,7 @@ namespace Catch {
|
|||||||
static struct sigaction oldSigActions [sizeof(signalDefs)/sizeof(SignalDefs)];
|
static struct sigaction oldSigActions [sizeof(signalDefs)/sizeof(SignalDefs)];
|
||||||
static stack_t oldSigStack;
|
static stack_t oldSigStack;
|
||||||
static char altStackMem[SIGSTKSZ];
|
static char altStackMem[SIGSTKSZ];
|
||||||
|
|
||||||
static void handleSignal( int sig ) {
|
static void handleSignal( int sig ) {
|
||||||
std::string name = "<unknown signal>";
|
std::string name = "<unknown signal>";
|
||||||
for (std::size_t i = 0; i < sizeof(signalDefs) / sizeof(SignalDefs); ++i) {
|
for (std::size_t i = 0; i < sizeof(signalDefs) / sizeof(SignalDefs); ++i) {
|
||||||
@ -141,8 +141,8 @@ namespace Catch {
|
|||||||
sigaction(signalDefs[i].id, &sa, &oldSigActions[i]);
|
sigaction(signalDefs[i].id, &sa, &oldSigActions[i]);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
~FatalConditionHandler() {
|
~FatalConditionHandler() {
|
||||||
reset();
|
reset();
|
||||||
}
|
}
|
||||||
@ -158,12 +158,12 @@ namespace Catch {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
bool FatalConditionHandler::isSet = false;
|
bool FatalConditionHandler::isSet = false;
|
||||||
struct sigaction FatalConditionHandler::oldSigActions[sizeof(signalDefs)/sizeof(SignalDefs)] = {};
|
struct sigaction FatalConditionHandler::oldSigActions[sizeof(signalDefs)/sizeof(SignalDefs)] = {};
|
||||||
stack_t FatalConditionHandler::oldSigStack = {};
|
stack_t FatalConditionHandler::oldSigStack = {};
|
||||||
char FatalConditionHandler::altStackMem[SIGSTKSZ] = {};
|
char FatalConditionHandler::altStackMem[SIGSTKSZ] = {};
|
||||||
|
|
||||||
|
|
||||||
} // namespace Catch
|
} // namespace Catch
|
||||||
|
|
||||||
|
@ -41,7 +41,7 @@ namespace Catch {
|
|||||||
Auto,
|
Auto,
|
||||||
Yes,
|
Yes,
|
||||||
No
|
No
|
||||||
}; };
|
}; };
|
||||||
|
|
||||||
class TestSpec;
|
class TestSpec;
|
||||||
|
|
||||||
|
@ -248,7 +248,7 @@ namespace Catch
|
|||||||
virtual void testRunEnded( TestRunStats const& testRunStats ) = 0;
|
virtual void testRunEnded( TestRunStats const& testRunStats ) = 0;
|
||||||
|
|
||||||
virtual void skipTest( TestCaseInfo const& testInfo ) = 0;
|
virtual void skipTest( TestCaseInfo const& testInfo ) = 0;
|
||||||
|
|
||||||
virtual MultipleReporters* tryAsMulti() { return CATCH_NULL; }
|
virtual MultipleReporters* tryAsMulti() { return CATCH_NULL; }
|
||||||
};
|
};
|
||||||
|
|
||||||
|
@ -52,7 +52,7 @@ namespace TestCaseTracking {
|
|||||||
virtual void addChild( Ptr<ITracker> const& child ) = 0;
|
virtual void addChild( Ptr<ITracker> const& child ) = 0;
|
||||||
virtual ITracker* findChild( NameAndLocation const& nameAndLocation ) = 0;
|
virtual ITracker* findChild( NameAndLocation const& nameAndLocation ) = 0;
|
||||||
virtual void openChild() = 0;
|
virtual void openChild() = 0;
|
||||||
|
|
||||||
// Debug/ checking
|
// Debug/ checking
|
||||||
virtual bool isSectionTracker() const = 0;
|
virtual bool isSectionTracker() const = 0;
|
||||||
virtual bool isIndexTracker() const = 0;
|
virtual bool isIndexTracker() const = 0;
|
||||||
@ -187,7 +187,7 @@ namespace TestCaseTracking {
|
|||||||
|
|
||||||
virtual bool isSectionTracker() const CATCH_OVERRIDE { return false; }
|
virtual bool isSectionTracker() const CATCH_OVERRIDE { return false; }
|
||||||
virtual bool isIndexTracker() const CATCH_OVERRIDE { return false; }
|
virtual bool isIndexTracker() const CATCH_OVERRIDE { return false; }
|
||||||
|
|
||||||
void open() {
|
void open() {
|
||||||
m_runState = Executing;
|
m_runState = Executing;
|
||||||
moveToThis();
|
moveToThis();
|
||||||
@ -261,7 +261,7 @@ namespace TestCaseTracking {
|
|||||||
virtual ~SectionTracker();
|
virtual ~SectionTracker();
|
||||||
|
|
||||||
virtual bool isSectionTracker() const CATCH_OVERRIDE { return true; }
|
virtual bool isSectionTracker() const CATCH_OVERRIDE { return true; }
|
||||||
|
|
||||||
static SectionTracker& acquire( TrackerContext& ctx, NameAndLocation const& nameAndLocation ) {
|
static SectionTracker& acquire( TrackerContext& ctx, NameAndLocation const& nameAndLocation ) {
|
||||||
SectionTracker* section = CATCH_NULL;
|
SectionTracker* section = CATCH_NULL;
|
||||||
|
|
||||||
@ -310,7 +310,7 @@ namespace TestCaseTracking {
|
|||||||
virtual ~IndexTracker();
|
virtual ~IndexTracker();
|
||||||
|
|
||||||
virtual bool isIndexTracker() const CATCH_OVERRIDE { return true; }
|
virtual bool isIndexTracker() const CATCH_OVERRIDE { return true; }
|
||||||
|
|
||||||
static IndexTracker& acquire( TrackerContext& ctx, NameAndLocation const& nameAndLocation, int size ) {
|
static IndexTracker& acquire( TrackerContext& ctx, NameAndLocation const& nameAndLocation, int size ) {
|
||||||
IndexTracker* tracker = CATCH_NULL;
|
IndexTracker* tracker = CATCH_NULL;
|
||||||
|
|
||||||
|
@ -90,12 +90,12 @@ std::string toString( char* const value ) {
|
|||||||
|
|
||||||
std::string toString( const wchar_t* const value )
|
std::string toString( const wchar_t* const value )
|
||||||
{
|
{
|
||||||
return value ? Catch::toString( std::wstring(value) ) : std::string( "{null string}" );
|
return value ? Catch::toString( std::wstring(value) ) : std::string( "{null string}" );
|
||||||
}
|
}
|
||||||
|
|
||||||
std::string toString( wchar_t* const value )
|
std::string toString( wchar_t* const value )
|
||||||
{
|
{
|
||||||
return Catch::toString( static_cast<const wchar_t*>( value ) );
|
return Catch::toString( static_cast<const wchar_t*>( value ) );
|
||||||
}
|
}
|
||||||
|
|
||||||
std::string toString( int value ) {
|
std::string toString( int value ) {
|
||||||
|
@ -108,12 +108,12 @@ namespace Catch {
|
|||||||
|
|
||||||
struct BySectionInfo {
|
struct BySectionInfo {
|
||||||
BySectionInfo( SectionInfo const& other ) : m_other( other ) {}
|
BySectionInfo( SectionInfo const& other ) : m_other( other ) {}
|
||||||
BySectionInfo( BySectionInfo const& other ) : m_other( other.m_other ) {}
|
BySectionInfo( BySectionInfo const& other ) : m_other( other.m_other ) {}
|
||||||
bool operator() ( Ptr<SectionNode> const& node ) const {
|
bool operator() ( Ptr<SectionNode> const& node ) const {
|
||||||
return node->stats.sectionInfo.lineInfo == m_other.lineInfo;
|
return node->stats.sectionInfo.lineInfo == m_other.lineInfo;
|
||||||
}
|
}
|
||||||
private:
|
private:
|
||||||
void operator=( BySectionInfo const& );
|
void operator=( BySectionInfo const& );
|
||||||
SectionInfo const& m_other;
|
SectionInfo const& m_other;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
@ -118,11 +118,11 @@ public: // IStreamingReporter
|
|||||||
++it )
|
++it )
|
||||||
(*it)->skipTest( testInfo );
|
(*it)->skipTest( testInfo );
|
||||||
}
|
}
|
||||||
|
|
||||||
virtual MultipleReporters* tryAsMulti() CATCH_OVERRIDE {
|
virtual MultipleReporters* tryAsMulti() CATCH_OVERRIDE {
|
||||||
return this;
|
return this;
|
||||||
}
|
}
|
||||||
|
|
||||||
};
|
};
|
||||||
|
|
||||||
Ptr<IStreamingReporter> addReporter( Ptr<IStreamingReporter> const& existingReporter, Ptr<IStreamingReporter> const& additionalReporter ) {
|
Ptr<IStreamingReporter> addReporter( Ptr<IStreamingReporter> const& existingReporter, Ptr<IStreamingReporter> const& additionalReporter ) {
|
||||||
|
@ -96,7 +96,7 @@ namespace Catch {
|
|||||||
if( assertionResult.hasExpression() ) {
|
if( assertionResult.hasExpression() ) {
|
||||||
m_xml.startElement( "Expression" )
|
m_xml.startElement( "Expression" )
|
||||||
.writeAttribute( "success", assertionResult.succeeded() )
|
.writeAttribute( "success", assertionResult.succeeded() )
|
||||||
.writeAttribute( "type", assertionResult.getTestMacroName() )
|
.writeAttribute( "type", assertionResult.getTestMacroName() )
|
||||||
.writeAttribute( "filename", assertionResult.getSourceInfo().file )
|
.writeAttribute( "filename", assertionResult.getSourceInfo().file )
|
||||||
.writeAttribute( "line", assertionResult.getSourceInfo().line );
|
.writeAttribute( "line", assertionResult.getSourceInfo().line );
|
||||||
|
|
||||||
|
@ -170,17 +170,17 @@ TEST_CASE
|
|||||||
|
|
||||||
REQUIRE(td != Approx(11.0));
|
REQUIRE(td != Approx(11.0));
|
||||||
REQUIRE(Approx(11.0) != td);
|
REQUIRE(Approx(11.0) != td);
|
||||||
|
|
||||||
REQUIRE(td <= Approx(10.0));
|
REQUIRE(td <= Approx(10.0));
|
||||||
REQUIRE(td <= Approx(11.0));
|
REQUIRE(td <= Approx(11.0));
|
||||||
REQUIRE(Approx(10.0) <= td);
|
REQUIRE(Approx(10.0) <= td);
|
||||||
REQUIRE(Approx(9.0) <= td);
|
REQUIRE(Approx(9.0) <= td);
|
||||||
|
|
||||||
REQUIRE(td >= Approx(9.0));
|
REQUIRE(td >= Approx(9.0));
|
||||||
REQUIRE(td >= Approx(10.0));
|
REQUIRE(td >= Approx(10.0));
|
||||||
REQUIRE(Approx(10.0) >= td);
|
REQUIRE(Approx(10.0) >= td);
|
||||||
REQUIRE(Approx(11.0) >= td);
|
REQUIRE(Approx(11.0) >= td);
|
||||||
|
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
|
@ -88,10 +88,10 @@ struct Fixture
|
|||||||
}
|
}
|
||||||
|
|
||||||
SCENARIO_METHOD(Fixture,
|
SCENARIO_METHOD(Fixture,
|
||||||
"BDD tests requiring Fixtures to provide commonly-accessed data or methods",
|
"BDD tests requiring Fixtures to provide commonly-accessed data or methods",
|
||||||
"[bdd][fixtures]") {
|
"[bdd][fixtures]") {
|
||||||
const int before(counter());
|
const int before(counter());
|
||||||
GIVEN("No operations precede me") {
|
GIVEN("No operations precede me") {
|
||||||
REQUIRE(before == 0);
|
REQUIRE(before == 0);
|
||||||
WHEN("We get the count") {
|
WHEN("We get the count") {
|
||||||
const int after(counter());
|
const int after(counter());
|
||||||
|
@ -210,29 +210,29 @@ TEST_CASE( "Comparisons with int literals don't warn when mixing signed/ unsigne
|
|||||||
|
|
||||||
TEST_CASE( "comparisons between int variables", "" )
|
TEST_CASE( "comparisons between int variables", "" )
|
||||||
{
|
{
|
||||||
long long_var = 1L;
|
long long_var = 1L;
|
||||||
unsigned char unsigned_char_var = 1;
|
unsigned char unsigned_char_var = 1;
|
||||||
unsigned short unsigned_short_var = 1;
|
unsigned short unsigned_short_var = 1;
|
||||||
unsigned int unsigned_int_var = 1;
|
unsigned int unsigned_int_var = 1;
|
||||||
unsigned long unsigned_long_var = 1L;
|
unsigned long unsigned_long_var = 1L;
|
||||||
|
|
||||||
REQUIRE( long_var == unsigned_char_var );
|
REQUIRE( long_var == unsigned_char_var );
|
||||||
REQUIRE( long_var == unsigned_short_var );
|
REQUIRE( long_var == unsigned_short_var );
|
||||||
REQUIRE( long_var == unsigned_int_var );
|
REQUIRE( long_var == unsigned_int_var );
|
||||||
REQUIRE( long_var == unsigned_long_var );
|
REQUIRE( long_var == unsigned_long_var );
|
||||||
}
|
}
|
||||||
|
|
||||||
TEST_CASE( "comparisons between const int variables", "" )
|
TEST_CASE( "comparisons between const int variables", "" )
|
||||||
{
|
{
|
||||||
const unsigned char unsigned_char_var = 1;
|
const unsigned char unsigned_char_var = 1;
|
||||||
const unsigned short unsigned_short_var = 1;
|
const unsigned short unsigned_short_var = 1;
|
||||||
const unsigned int unsigned_int_var = 1;
|
const unsigned int unsigned_int_var = 1;
|
||||||
const unsigned long unsigned_long_var = 1L;
|
const unsigned long unsigned_long_var = 1L;
|
||||||
|
|
||||||
REQUIRE( unsigned_char_var == 1 );
|
REQUIRE( unsigned_char_var == 1 );
|
||||||
REQUIRE( unsigned_short_var == 1 );
|
REQUIRE( unsigned_short_var == 1 );
|
||||||
REQUIRE( unsigned_int_var == 1 );
|
REQUIRE( unsigned_int_var == 1 );
|
||||||
REQUIRE( unsigned_long_var == 1 );
|
REQUIRE( unsigned_long_var == 1 );
|
||||||
}
|
}
|
||||||
|
|
||||||
TEST_CASE( "Comparisons between unsigned ints and negative signed ints match c++ standard behaviour", "" )
|
TEST_CASE( "Comparisons between unsigned ints and negative signed ints match c++ standard behaviour", "" )
|
||||||
|
@ -15,9 +15,9 @@ namespace
|
|||||||
{
|
{
|
||||||
inline int thisThrows()
|
inline int thisThrows()
|
||||||
{
|
{
|
||||||
if( Catch::alwaysTrue() )
|
if( Catch::alwaysTrue() )
|
||||||
throw std::domain_error( "expected exception" );
|
throw std::domain_error( "expected exception" );
|
||||||
return 1;
|
return 1;
|
||||||
}
|
}
|
||||||
|
|
||||||
int thisDoesntThrow()
|
int thisDoesntThrow()
|
||||||
@ -42,23 +42,23 @@ TEST_CASE( "Expected exceptions that don't throw or unexpected exceptions fail t
|
|||||||
|
|
||||||
TEST_CASE( "When unchecked exceptions are thrown directly they are always failures", "[.][failing][!throws]" )
|
TEST_CASE( "When unchecked exceptions are thrown directly they are always failures", "[.][failing][!throws]" )
|
||||||
{
|
{
|
||||||
if( Catch::alwaysTrue() )
|
if( Catch::alwaysTrue() )
|
||||||
throw std::domain_error( "unexpected exception" );
|
throw std::domain_error( "unexpected exception" );
|
||||||
}
|
}
|
||||||
|
|
||||||
TEST_CASE( "An unchecked exception reports the line of the last assertion", "[.][failing][!throws]" )
|
TEST_CASE( "An unchecked exception reports the line of the last assertion", "[.][failing][!throws]" )
|
||||||
{
|
{
|
||||||
CHECK( 1 == 1 );
|
CHECK( 1 == 1 );
|
||||||
if( Catch::alwaysTrue() )
|
if( Catch::alwaysTrue() )
|
||||||
throw std::domain_error( "unexpected exception" );
|
throw std::domain_error( "unexpected exception" );
|
||||||
}
|
}
|
||||||
|
|
||||||
TEST_CASE( "When unchecked exceptions are thrown from sections they are always failures", "[.][failing][!throws]" )
|
TEST_CASE( "When unchecked exceptions are thrown from sections they are always failures", "[.][failing][!throws]" )
|
||||||
{
|
{
|
||||||
SECTION( "section name", "" )
|
SECTION( "section name", "" )
|
||||||
{
|
{
|
||||||
if( Catch::alwaysTrue() )
|
if( Catch::alwaysTrue() )
|
||||||
throw std::domain_error( "unexpected exception" );
|
throw std::domain_error( "unexpected exception" );
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -145,8 +145,8 @@ CATCH_TRANSLATE_EXCEPTION( double& ex )
|
|||||||
|
|
||||||
TEST_CASE("Non-std exceptions can be translated", "[.][failing][!throws]" )
|
TEST_CASE("Non-std exceptions can be translated", "[.][failing][!throws]" )
|
||||||
{
|
{
|
||||||
if( Catch::alwaysTrue() )
|
if( Catch::alwaysTrue() )
|
||||||
throw CustomException( "custom exception" );
|
throw CustomException( "custom exception" );
|
||||||
}
|
}
|
||||||
|
|
||||||
TEST_CASE("Custom std-exceptions can be custom translated", "[.][failing][!throws]" )
|
TEST_CASE("Custom std-exceptions can be custom translated", "[.][failing][!throws]" )
|
||||||
@ -156,8 +156,8 @@ TEST_CASE("Custom std-exceptions can be custom translated", "[.][failing][!throw
|
|||||||
}
|
}
|
||||||
|
|
||||||
inline void throwCustom() {
|
inline void throwCustom() {
|
||||||
if( Catch::alwaysTrue() )
|
if( Catch::alwaysTrue() )
|
||||||
throw CustomException( "custom exception - not std" );
|
throw CustomException( "custom exception - not std" );
|
||||||
}
|
}
|
||||||
|
|
||||||
TEST_CASE( "Custom exceptions can be translated when testing for nothrow", "[.][failing][!throws]" )
|
TEST_CASE( "Custom exceptions can be translated when testing for nothrow", "[.][failing][!throws]" )
|
||||||
@ -173,8 +173,8 @@ TEST_CASE( "Custom exceptions can be translated when testing for throwing as som
|
|||||||
|
|
||||||
TEST_CASE( "Unexpected exceptions can be translated", "[.][failing][!throws]" )
|
TEST_CASE( "Unexpected exceptions can be translated", "[.][failing][!throws]" )
|
||||||
{
|
{
|
||||||
if( Catch::alwaysTrue() )
|
if( Catch::alwaysTrue() )
|
||||||
throw double( 3.14 );
|
throw double( 3.14 );
|
||||||
}
|
}
|
||||||
|
|
||||||
inline int thisFunctionNotImplemented( int ) {
|
inline int thisFunctionNotImplemented( int ) {
|
||||||
|
@ -196,13 +196,13 @@ TEST_CASE( "Process can be configured on command line", "[config][command-line]"
|
|||||||
}
|
}
|
||||||
|
|
||||||
SECTION( "use-colour", "") {
|
SECTION( "use-colour", "") {
|
||||||
|
|
||||||
using Catch::UseColour;
|
using Catch::UseColour;
|
||||||
|
|
||||||
SECTION( "without option", "" ) {
|
SECTION( "without option", "" ) {
|
||||||
const char* argv[] = { "test" };
|
const char* argv[] = { "test" };
|
||||||
CHECK_NOTHROW( parseIntoConfig( argv, config ) );
|
CHECK_NOTHROW( parseIntoConfig( argv, config ) );
|
||||||
|
|
||||||
REQUIRE( config.useColour == UseColour::Auto );
|
REQUIRE( config.useColour == UseColour::Auto );
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -216,14 +216,14 @@ TEST_CASE( "Process can be configured on command line", "[config][command-line]"
|
|||||||
SECTION( "yes", "" ) {
|
SECTION( "yes", "" ) {
|
||||||
const char* argv[] = { "test", "--use-colour", "yes" };
|
const char* argv[] = { "test", "--use-colour", "yes" };
|
||||||
CHECK_NOTHROW( parseIntoConfig( argv, config ) );
|
CHECK_NOTHROW( parseIntoConfig( argv, config ) );
|
||||||
|
|
||||||
REQUIRE( config.useColour == UseColour::Yes );
|
REQUIRE( config.useColour == UseColour::Yes );
|
||||||
}
|
}
|
||||||
|
|
||||||
SECTION( "no", "" ) {
|
SECTION( "no", "" ) {
|
||||||
const char* argv[] = { "test", "--use-colour", "no" };
|
const char* argv[] = { "test", "--use-colour", "no" };
|
||||||
CHECK_NOTHROW( parseIntoConfig( argv, config ) );
|
CHECK_NOTHROW( parseIntoConfig( argv, config ) );
|
||||||
|
|
||||||
REQUIRE( config.useColour == UseColour::No );
|
REQUIRE( config.useColour == UseColour::No );
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -24,6 +24,7 @@ def fixFile( path ):
|
|||||||
changed = 0
|
changed = 0
|
||||||
for line in f:
|
for line in f:
|
||||||
trimmed = line.rstrip() + "\n"
|
trimmed = line.rstrip() + "\n"
|
||||||
|
trimmed = trimmed.replace('\t', ' ')
|
||||||
if trimmed != line:
|
if trimmed != line:
|
||||||
changed = changed +1
|
changed = changed +1
|
||||||
lines.append( trimmed )
|
lines.append( trimmed )
|
Loading…
Reference in New Issue
Block a user