3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2025-11-04 14:09:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

Avoid copying Clara::Parser for every inserted Opt

Browse Source 
This prevents the full construction from being O(N^2) in number
of `Opt`s, and also reduces the number of allocations for running
no tests significantly:

`tests/SelfTest`: 7705 -> 6095
`tests/ExtraTests/NoTests` 2215 -> 605
This commit is contained in:
Martin Hořeňovský
2023-12-26 11:55:19 +01:00
parent 822c44a203
commit c57e349d1d
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/catch2/internal/catch_clara.hpp
View File

@@ -636,8 +636,14 @@ namespace Catch {
Parser& operator|=(Parser const& other); Parser& operator|=(Parser const& other);
template <typename T> template <typename T>
auto operator|(T const& other) const -> Parser { friend Parser operator|(Parser const& p, T const& rhs) {
return Parser(*this) |= other; return Parser( p ) |= rhs;
}
template <typename T>
friend Parser operator|( Parser&& p, T const& rhs ) {
p |= rhs;
return CATCH_MOVE(p);
} }
std::vector<Detail::HelpColumns> getHelpColumns() const; std::vector<Detail::HelpColumns> getHelpColumns() const;