3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2024-11-22 13:26:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove SourceLineInfo::empty()

Browse Source
This commit is contained in:
Martin Hořeňovský 2019-10-30 18:01:38 +01:00
parent ac4958395c
commit ca4c6218d4
No known key found for this signature in database
GPG Key ID: DE48307B8B0D381A
2 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
docs/deprecations.md
View File

@ -9,14 +9,6 @@ either of these is a breaking change, and thus will not happen until
at least the next major release. at least the next major release.
## Deprecations
### SourceLineInfo::empty()
There should be no reason to ever have an empty `SourceLineInfo`, so the
method will be removed.
## Planned changes ## Planned changes
### `CHECKED_IF` and `CHECKED_ELSE` ### `CHECKED_IF` and `CHECKED_ELSE`

5
include/internal/catch_common.h
View File

@ -47,8 +47,8 @@ namespace Catch {
struct SourceLineInfo { struct SourceLineInfo {
SourceLineInfo() = delete; SourceLineInfo() = delete;
SourceLineInfo( char const* _file, std::size_t _line ) noexcept constexpr SourceLineInfo( char const* _file, std::size_t _line ) noexcept:
: file( _file ), file( _file ),
line( _line ) line( _line )
{} {}
@ -57,7 +57,6 @@ namespace Catch {
SourceLineInfo( SourceLineInfo&& ) noexcept = default; SourceLineInfo( SourceLineInfo&& ) noexcept = default;
SourceLineInfo& operator = ( SourceLineInfo&& ) noexcept = default; SourceLineInfo& operator = ( SourceLineInfo&& ) noexcept = default;
bool empty() const noexcept { return file[0] == '\0'; }
bool operator == ( SourceLineInfo const& other ) const noexcept; bool operator == ( SourceLineInfo const& other ) const noexcept;
bool operator < ( SourceLineInfo const& other ) const noexcept; bool operator < ( SourceLineInfo const& other ) const noexcept;