From ce128f584c293b17362d838a8dc65bc81ffc8dff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Ho=C5=99e=C5=88ovsk=C3=BD?= Date: Sun, 20 Jul 2025 18:31:24 +0200 Subject: [PATCH] Remove assertionPassed fast path from the capture interface As it is an internal helper for RunContext to speed-up handling of succesfull assertions, I have no idea why it was added to the interface back when it was first implemented. --- src/catch2/interfaces/catch_interfaces_capture.hpp | 2 -- src/catch2/internal/catch_run_context.hpp | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/catch2/interfaces/catch_interfaces_capture.hpp b/src/catch2/interfaces/catch_interfaces_capture.hpp index 9e5431d2..dc9500b6 100644 --- a/src/catch2/interfaces/catch_interfaces_capture.hpp +++ b/src/catch2/interfaces/catch_interfaces_capture.hpp @@ -93,9 +93,7 @@ namespace Catch { AssertionReaction &reaction ) = 0; - virtual bool lastAssertionPassed() = 0; - virtual void assertionPassed() = 0; // Deprecated, do not use: virtual std::string getCurrentTestName() const = 0; diff --git a/src/catch2/internal/catch_run_context.hpp b/src/catch2/internal/catch_run_context.hpp index da320fe8..9626e448 100644 --- a/src/catch2/internal/catch_run_context.hpp +++ b/src/catch2/internal/catch_run_context.hpp @@ -108,7 +108,7 @@ namespace Catch { bool lastAssertionPassed() override; - void assertionPassed() override; + void assertionPassed(); public: // !TBD We need to do this another way!