3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2024-11-22 21:36:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Tiny speedup when listing tags

Browse Source 
Noticed that the code was originally concatenating strings just to
then append the result to another string. Now it does not create
temporaries and also preallocates the string buffer.
This commit is contained in:
Martin Hořeňovský 2019-08-05 19:12:25 +02:00
parent 3701c2e2e6
commit cf55cfd76f
No known key found for this signature in database
GPG Key ID: DE48307B8B0D381A
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
include/internal/catch_list.cpp
View File

@ -84,9 +84,18 @@ namespace Catch {
} }
std::string TagInfo::all() const { std::string TagInfo::all() const {
std::string out; size_t size = 0;
for( auto const& spelling : spellings ) for (auto const& spelling : spellings) {
out += "[" + spelling + "]"; // Add 2 for the brackes
size += spelling.size() + 2;
}
std::string out; out.reserve(size);
for (auto const& spelling : spellings) {
out += '[';
out += spelling;
out += ']';
}
return out; return out;
} }