3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2025-11-04 22:19:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused partial specialization for MatcherMethod<T>

Browse Source 
No matcher actually uses it, and there is no good reason for it,
as the best it can do for user is removing a single indirection
when using the pointer inside the matcher. Given the overhead of
other code that will be running during such time, it is completely
meaningless.

This also fixes compilation for PredicateMatcher<const char*>.
This commit is contained in:
Martin Hořeňovský
2018-11-04 00:00:36 +01:00
parent 03d122a35c
commit d0eb9dfb9b
7 changed files with 36 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
projects/SelfTest/Baselines/xml.sw.approved.txt
View File

@@ -5964,6 +5964,17 @@
</Expression>
<OverallResult success="true"/>
</TestCase>
<TestCase name="Predicate matcher can accept const char*" tags="[compilation][matchers]" filename="projects/<exe-name>/UsageTests/Matchers.tests.cpp" >
<Expression success="true" type="REQUIRE_THAT" filename="projects/<exe-name>/UsageTests/Matchers.tests.cpp" >
<Original>
"foo", Predicate&lt;const char*>([] (const char* const&amp;) { return true; })
</Original>
<Expanded>
"foo" matches undescribed predicate
</Expanded>
</Expression>
<OverallResult success="true"/>
</TestCase>
<TestCase name="Process can be configured on command line" tags="[command-line][config]" filename="projects/<exe-name>/IntrospectiveTests/CmdLine.tests.cpp" >
<Section name="empty args don't cause a crash" filename="projects/<exe-name>/IntrospectiveTests/CmdLine.tests.cpp" >
<Expression success="true" type="CHECK" filename="projects/<exe-name>/IntrospectiveTests/CmdLine.tests.cpp" >
@@ -11358,7 +11369,7 @@ loose text artifact
</Section>
<OverallResult success="true"/>
</TestCase>
<OverallResults successes="1104" failures="123" expectedFailures="21"/>
<OverallResults successes="1105" failures="123" expectedFailures="21"/>
</Group>
<OverallResults successes="1104" failures="122" expectedFailures="21"/>
<OverallResults successes="1105" failures="122" expectedFailures="21"/>
</Catch>