3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2024-11-22 21:36:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't call strlen in StringRef when the length was already passed

Browse Source
This commit is contained in:
Martin Hořeňovský 2017-11-13 12:03:45 +01:00
parent 3537b7858f
commit e7c23b73da
1 changed files with 12 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/internal/catch_stringref.cpp
View File

@ -53,11 +53,7 @@ namespace Catch {
StringRef::StringRef( char const* rawChars, size_type size ) noexcept StringRef::StringRef( char const* rawChars, size_type size ) noexcept
: m_start( rawChars ), : m_start( rawChars ),
m_size( size ) m_size( size )
{ {}
size_type rawSize = rawChars == nullptr ? 0 : static_cast<size_type>( std::strlen( rawChars ) );
if( rawSize < size )
m_size = rawSize;
}
StringRef::StringRef( std::string const& stdString ) noexcept StringRef::StringRef( std::string const& stdString ) noexcept
: m_start( stdString.c_str() ), : m_start( stdString.c_str() ),