3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2025-08-01 12:55:40 +02:00
Code Issues Packages Projects Releases Wiki Activity

Take std::string by const-ref where possible

Browse Source 
Most places already do, this brings over some forgotten places.

Also close #842
This commit is contained in:
Martin Hořeňovský
2017-03-06 13:16:43 +01:00
parent 932a405e18
commit e95bf48445
5 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/reporters/catch_reporter_compact.hpp
View File

@@ -169,7 +169,7 @@ namespace Catch {
stream << result.getSourceInfo() << ':';
}
void printResultType( Colour::Code colour, std::string passOrFail ) const {
void printResultType( Colour::Code colour, std::string const& passOrFail ) const {
if( !passOrFail.empty() ) {
{
Colour colourGuard( colour );
@@ -179,7 +179,7 @@ namespace Catch {
}
}
void printIssue( std::string issue ) const {
void printIssue( std::string const& issue ) const {
stream << ' ' << issue;
}

4
include/reporters/catch_reporter_tap.hpp
View File

@@ -157,13 +157,13 @@ namespace Catch {
stream << result.getSourceInfo() << ":";
}
void printResultType( std::string passOrFail ) const {
void printResultType( std::string const& passOrFail ) const {
if( !passOrFail.empty() ) {
stream << passOrFail << ' ' << counter << " -";
}
}
void printIssue( std::string issue ) const {
void printIssue( std::string const& issue ) const {
stream << " " << issue;
}