Apply some IWYU suggestions

This is not nearly all of them, because IWYU does not support the
way Catch2 manages includes -- it expects that non-system includes
are done using `#include "foo/bar/baz.hpp"`, while Catch2 uses
`<foo/bar/baz.hpp>`. This causes trouble, because IWYU suggests
removing every single internal header, and then adding them again,
but using `""` in the include directive... the resulting suggestions
cannot be used without a lot of manual work, as they are largely
bogus.

For bonus points, IWYU also _loves_ to suggest kinda-random stdlib
headers for `size_t` and similar. Still, the resulting inclusion
graph is somewhat better than it was before.

src/catch2/benchmark/detail/catch_stats.hpp

@@ -11,17 +11,15 @@
 #ifndef TWOBLUECUBES_CATCH_DETAIL_ANALYSIS_HPP_INCLUDED
 #define TWOBLUECUBES_CATCH_DETAIL_ANALYSIS_HPP_INCLUDED
 
-#include <catch2/benchmark/catch_clock.hpp>
 #include <catch2/benchmark/catch_estimate.hpp>
 #include <catch2/benchmark/catch_outlier_classification.hpp>
 
 #include <algorithm>
-#include <functional>
 #include <vector>
 #include <numeric>
+#include <tuple>
 #include <cmath>
 #include <utility>
-#include <cstddef>
 
 namespace Catch {
     namespace Benchmark {
@@ -64,7 +62,8 @@ namespace Catch {
             template <typename Estimator, typename Iterator>
             sample jackknife(Estimator&& estimator, Iterator first, Iterator last) {
                 auto n = last - first;
-                auto second = std::next(first);
+                auto second = first;
+                ++second;
                 sample results;
                 results.reserve(n);
 

src/catch2/catch_config.cpp

@@ -11,6 +11,8 @@
 #include <catch2/internal/catch_stringref.hpp>
 #include <catch2/internal/catch_string_manip.hpp>
 #include <catch2/internal/catch_test_spec_parser.hpp>
+#include <catch2/interfaces/catch_interfaces_tag_alias_registry.hpp>
+
 
 namespace Catch {
 

src/catch2/catch_session.cpp

@@ -18,14 +18,11 @@
 #include <catch2/internal/catch_random_number_generator.hpp>
 #include <catch2/internal/catch_startup_exception_registry.hpp>
 #include <catch2/internal/catch_text.hpp>
-#include <catch2/internal/catch_stream.hpp>
 #include <catch2/internal/catch_windows_h_proxy.hpp>
 #include <catch2/reporters/catch_reporter_listening.hpp>
 
-#include <cstdlib>
 #include <iomanip>
 #include <set>
-#include <iterator>
 
 namespace Catch {
 

src/catch2/catch_session.hpp

@@ -10,7 +10,6 @@
 
 #include <catch2/internal/catch_commandline.hpp>
 #include <catch2/catch_config.hpp>
-#include <catch2/internal/catch_text.hpp>
 #include <catch2/internal/catch_unique_ptr.hpp>
 
 namespace Catch {

src/catch2/catch_test_case_info.cpp

@@ -12,10 +12,9 @@
 #include <catch2/interfaces/catch_interfaces_testcase.hpp>
 #include <catch2/internal/catch_string_manip.hpp>
 
+#include <cassert>
 #include <cctype>
-#include <exception>
 #include <algorithm>
-#include <sstream>
 
 namespace Catch {
 

src/catch2/catch_test_spec.cpp

@@ -7,7 +7,6 @@
 
 #include <catch2/catch_test_spec.hpp>
 #include <catch2/internal/catch_string_manip.hpp>
-#include <catch2/interfaces/catch_interfaces_config.hpp>
 #include <catch2/catch_test_case_info.hpp>
 
 #include <algorithm>

src/catch2/internal/catch_assertion_handler.cpp

@@ -7,8 +7,6 @@
  */
 
 #include <catch2/internal/catch_assertion_handler.hpp>
-#include <catch2/catch_assertion_result.hpp>
-#include <catch2/interfaces/catch_interfaces_runner.hpp>
 #include <catch2/interfaces/catch_interfaces_config.hpp>
 #include <catch2/internal/catch_context.hpp>
 #include <catch2/internal/catch_enforce.hpp>

src/catch2/internal/catch_clara.hpp

@@ -9,6 +9,9 @@
 #ifndef TWOBLUECUBES_CATCH_CLARA_H_INCLUDED
 #define TWOBLUECUBES_CATCH_CLARA_H_INCLUDED
 
+// For CATCH_CONFIG_CONSOLE_WIDTH. We should refactor this out somewhere else.
+#include <catch2/catch_config.hpp>
+
 // Use Catch's value for console width (store Clara's off to the side, if present)
 #ifdef CLARA_CONFIG_CONSOLE_WIDTH
 #define CATCH_TEMP_CLARA_CONFIG_CONSOLE_WIDTH CATCH_CLARA_TEXTFLOW_CONFIG_CONSOLE_WIDTH

src/catch2/internal/catch_commandline.cpp

@@ -8,11 +8,12 @@
 
 #include <catch2/internal/catch_commandline.hpp>
 
+#include <catch2/catch_config.hpp>
 #include <catch2/internal/catch_string_manip.hpp>
-
 #include <catch2/interfaces/catch_interfaces_registry_hub.hpp>
 #include <catch2/interfaces/catch_interfaces_reporter.hpp>
 
+#include <algorithm>
 #include <fstream>
 #include <ctime>
 

src/catch2/internal/catch_commandline.hpp

@@ -8,11 +8,12 @@
 #ifndef TWOBLUECUBES_CATCH_COMMANDLINE_HPP_INCLUDED
 #define TWOBLUECUBES_CATCH_COMMANDLINE_HPP_INCLUDED
 
-#include <catch2/catch_config.hpp>
 #include <catch2/internal/catch_clara.hpp>
 
 namespace Catch {
 
+    struct ConfigData;
+
     clara::Parser makeCommandLineParser( ConfigData& config );
 
 } // end namespace Catch

src/catch2/internal/catch_common.cpp

@@ -7,8 +7,6 @@
  */
 
 #include <catch2/internal/catch_common.hpp>
-#include <catch2/internal/catch_context.hpp>
-#include <catch2/interfaces/catch_interfaces_config.hpp>
 
 #include <cstring>
 #include <ostream>

src/catch2/internal/catch_common.hpp

@@ -20,8 +20,6 @@
 #endif
 
 #include <iosfwd>
-#include <string>
-#include <cstdint>
 
 // We need a dummy global operator<< so we can bring it into Catch namespace later
 struct Catch_global_namespace_dummy {};

src/catch2/internal/catch_console_colour.cpp

@@ -23,7 +23,7 @@
 #include <catch2/internal/catch_debugger.hpp>
 #include <catch2/internal/catch_windows_h_proxy.hpp>
 
-#include <sstream>
+#include <ostream>
 
 namespace Catch {
     namespace {

src/catch2/internal/catch_context.hpp

@@ -13,7 +13,6 @@ namespace Catch {
     struct IResultCapture;
     struct IRunner;
     struct IConfig;
-    struct IMutableContext;
 
     struct IContext
     {

src/catch2/internal/catch_enum_values_registry.cpp

@@ -9,7 +9,6 @@
 #include <catch2/internal/catch_string_manip.hpp>
 #include <catch2/internal/catch_stream.hpp>
 
-#include <map>
 #include <cassert>
 
 namespace Catch {

src/catch2/internal/catch_enum_values_registry.hpp

@@ -10,6 +10,7 @@
 
 #include <catch2/interfaces/catch_interfaces_enum_values_registry.hpp>
 #include <catch2/internal/catch_unique_ptr.hpp>
+#include <catch2/internal/catch_stringref.hpp>
 
 #include <vector>
 

src/catch2/internal/catch_list.cpp

@@ -13,18 +13,12 @@
 #include <catch2/interfaces/catch_interfaces_testcase.hpp>
 
 #include <catch2/internal/catch_context.hpp>
+#include <catch2/catch_config.hpp>
 #include <catch2/internal/catch_stream.hpp>
-
-#include <catch2/internal/catch_console_colour.hpp>
 #include <catch2/internal/catch_test_spec_parser.hpp>
-#include <catch2/catch_tostring.hpp>
 #include <catch2/internal/catch_string_manip.hpp>
 #include <catch2/catch_test_case_info.hpp>
 
-#include <limits>
-#include <algorithm>
-#include <set>
-
 namespace Catch {
     namespace {
 

src/catch2/internal/catch_list.hpp

@@ -8,7 +8,6 @@
 #ifndef TWOBLUECUBES_CATCH_LIST_H_INCLUDED
 #define TWOBLUECUBES_CATCH_LIST_H_INCLUDED
 
-#include <catch2/catch_config.hpp>
 #include <catch2/internal/catch_stringref.hpp>
 
 #include <set>
@@ -18,6 +17,8 @@
 namespace Catch {
 
     struct IStreamingReporter;
+    class Config;
+
 
     struct ReporterDescription {
         std::string name, description;

src/catch2/internal/catch_run_context.cpp

@@ -1,4 +1,5 @@
 #include <catch2/interfaces/catch_interfaces_generatortracker.hpp>
+#include <catch2/interfaces/catch_interfaces_config.hpp>
 #include <catch2/internal/catch_run_context.hpp>
 #include <catch2/internal/catch_compiler_capabilities.hpp>
 #include <catch2/internal/catch_context.hpp>
@@ -8,6 +9,7 @@
 #include <catch2/internal/catch_stream.hpp>
 #include <catch2/catch_timer.hpp>
 #include <catch2/internal/catch_output_redirect.hpp>
+#include <catch2/internal/catch_assertion_handler.hpp>
 
 #include <cassert>
 #include <algorithm>

src/catch2/internal/catch_run_context.hpp

@@ -10,14 +10,13 @@
 
 #include <catch2/interfaces/catch_interfaces_runner.hpp>
 #include <catch2/interfaces/catch_interfaces_reporter.hpp>
-#include <catch2/catch_config.hpp>
 #include <catch2/internal/catch_test_registry.hpp>
 #include <catch2/catch_test_case_info.hpp>
-#include <catch2/internal/catch_test_macro_impl.hpp>
 #include <catch2/catch_message.hpp>
 #include <catch2/catch_totals.hpp>
 #include <catch2/internal/catch_test_case_tracker.hpp>
-#include <catch2/internal/catch_assertion_handler.hpp>
+#include <catch2/catch_assertion_info.hpp>
+#include <catch2/catch_assertion_result.hpp>
 
 #include <string>
 
@@ -25,6 +24,7 @@ namespace Catch {
 
     struct IMutableContext;
     struct IGeneratorTracker;
+    struct IConfig;
 
     ///////////////////////////////////////////////////////////////////////////
 

src/catch2/internal/catch_tag_alias_registry.cpp

@@ -12,8 +12,6 @@
 #include <catch2/interfaces/catch_interfaces_registry_hub.hpp>
 #include <catch2/internal/catch_string_manip.hpp>
 
-#include <sstream>
-
 namespace Catch {
 
     TagAliasRegistry::~TagAliasRegistry() {}

src/catch2/internal/catch_tag_alias_registry.hpp

@@ -12,6 +12,7 @@
 #include <catch2/catch_tag_alias.hpp>
 
 #include <map>
+#include <string>
 
 namespace Catch {
 

src/catch2/internal/catch_test_case_registry_impl.cpp

@@ -17,9 +17,7 @@
 #include <catch2/catch_test_spec.hpp>
 
 #include <algorithm>
-#include <iterator>
+#include <set>
-#include <random>
-#include <sstream>
 
 namespace Catch {
 

src/catch2/internal/catch_test_case_registry_impl.hpp

@@ -12,8 +12,6 @@
 #include <catch2/interfaces/catch_interfaces_config.hpp>
 
 #include <vector>
-#include <set>
-#include <algorithm>
 
 namespace Catch {
 

src/catch2/internal/catch_test_case_tracker.cpp

@@ -13,7 +13,6 @@
 #include <algorithm>
 #include <cassert>
 #include <memory>
-#include <sstream>
 
 #if defined(__clang__)
 #    pragma clang diagnostic push

src/catch2/internal/catch_test_spec_parser.cpp

@@ -8,6 +8,7 @@
 #include <catch2/internal/catch_test_spec_parser.hpp>
 
 #include <catch2/internal/catch_string_manip.hpp>
+#include <catch2/interfaces/catch_interfaces_tag_alias_registry.hpp>
 
 
 namespace Catch {

src/catch2/internal/catch_test_spec_parser.hpp

@@ -14,10 +14,14 @@
 #endif
 
 #include <catch2/catch_test_spec.hpp>
-#include <catch2/interfaces/catch_interfaces_tag_alias_registry.hpp>
+
+#include <vector>
+#include <string>
 
 namespace Catch {
 
+    struct ITagAliasRegistry;
+
     class TestSpecParser {
         enum Mode{ None, Name, QuotedName, Tag, EscapedName };
         Mode m_mode = None;

src/catch2/matchers/catch_matchers_floating.cpp

@@ -17,7 +17,6 @@
 #include <cstdint>
 #include <cstring>
 #include <sstream>
-#include <type_traits>
 #include <iomanip>
 #include <limits>
 

src/catch2/matchers/catch_matchers_templated.hpp

@@ -10,7 +10,6 @@
 
 #include <array>
 #include <algorithm>
-#include <memory>
 #include <string>
 #include <type_traits>
 #include <utility>

src/catch2/reporters/catch_reporter_listening.cpp

@@ -6,7 +6,8 @@
  *  file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
  */
 
- #include <catch2/reporters/catch_reporter_listening.hpp>
+#include <catch2/reporters/catch_reporter_listening.hpp>
+
 #include <cassert>
 
 namespace Catch {

src/catch2/reporters/catch_reporter_teamcity.cpp

@@ -10,6 +10,8 @@
 #include <catch2/internal/catch_text.hpp>
 #include <catch2/catch_test_case_info.hpp>
 
+#include <cassert>
+
 namespace Catch {
 
     namespace {