3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2025-08-02 13:25:41 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve performance of SonarQube reporter handling passing assertions

Browse Source 
This mirrors the changes done to the JUnit reporter in commit
fe483c056d
This commit is contained in:
Martin Hořeňovský
2024-08-14 12:32:44 +02:00
parent 35c3403fbb
commit fa306fc85e
4 changed files with 311 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/catch2/reporters/catch_reporter_sonarqube.cpp
View File

@@ -73,9 +73,9 @@ namespace Catch {
if (!rootName.empty())
name = rootName + '/' + name;
if ( sectionNode.hasAnyAssertions()
if ( sectionNode.stats.assertions.total() > 0
|| !sectionNode.stdOut.empty()
|| !sectionNode.stdErr.empty() ) {
|| !sectionNode.stdErr.empty() ) {
XmlWriter::ScopedElement e = xml.scopedElement("testCase");
xml.writeAttribute("name"_sr, name);
xml.writeAttribute("duration"_sr, static_cast<long>(sectionNode.stats.durationInSeconds * 1000));

2
src/catch2/reporters/catch_reporter_sonarqube.hpp
View File

@@ -21,7 +21,7 @@ namespace Catch {
: CumulativeReporterBase(CATCH_MOVE(config))
, xml(m_stream) {
m_preferences.shouldRedirectStdOut = true;
m_preferences.shouldReportAllAssertions = true;
m_preferences.shouldReportAllAssertions = false;
m_shouldStoreSuccesfulAssertions = false;
}