From ff2b3c85a7facd042f36e00974024753ef15535e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Ho=C5=99e=C5=88ovsk=C3=BD?= Date: Sun, 1 Jul 2018 21:47:19 +0200 Subject: [PATCH] Add comment explaining why we leak -Wparentheses under g++ --- include/internal/catch_suppress_warnings.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/internal/catch_suppress_warnings.h b/include/internal/catch_suppress_warnings.h index bbdb0c49..25d90125 100644 --- a/include/internal/catch_suppress_warnings.h +++ b/include/internal/catch_suppress_warnings.h @@ -16,6 +16,9 @@ # pragma clang diagnostic ignored "-Wcovered-switch-default" # endif #elif defined __GNUC__ + // GCC likes to warn on REQUIREs, and we cannot suppress them + // locally because g++'s support for _Pragma is lacking in older, + // still supported, versions # pragma GCC diagnostic ignored "-Wparentheses" # pragma GCC diagnostic push # pragma GCC diagnostic ignored "-Wunused-variable"