3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2024-11-17 19:22:25 +01:00
Code Issues Packages Projects Releases Wiki Activity
0b993d7436
catch2/include/internal
History
Tiago Macarios 0b993d7436 Fix catch exception by reference 
When compiling our codebase with clang we were getting the following
error:

GSL/tests/algorithm_tests.cpp:198:58: warning: catch handler catches by
value; should catch by reference instead
[misc-throw-by-value-catch-by-reference]
    CHECK_THROWS_AS(copy(src_span_dyn, dst_span_static), fail_fast);
                                                             ^
Looking at the catch source code exceptions were being caught by value.
One could have it designed so that users might say:

CHECK_THROWS_AS(copy(src_span_dyn, dst_span_static), fail_fast&);

But I don't think this is the intent and looking at the Catch tests
itself looks like this macro does not expect the reference:

    REQUIRE_THROWS_AS( thisThrows(), std::domain_error );
    CHECK_THROWS_AS( thisDoesntThrow(), std::domain_error );

This commit makes Catch catch exceptions by reference instead of by
value.
2017-10-24 20:58:23 -07:00
..
catch_approx.hpp Addressed some static analysis warnings 2017-07-19 09:50:08 +02:00
catch_assertionresult.h Address some of the Resharper finds for Catch 1 2017-07-31 12:31:45 +02:00
catch_assertionresult.hpp Fixed expansion of _FALSE binary expression 2017-10-13 19:44:20 +01:00
catch_capture.hpp Fix catch exception by reference 2017-10-24 20:58:23 -07:00
catch_clara.h New version of Clara 2014-03-17 18:40:58 +00:00
catch_commandline.hpp Remove duplicate CLI option 2017-08-28 12:16:23 +02:00
catch_common.h Addressed some static analysis warnings 2017-07-19 09:50:08 +02:00
catch_common.hpp Removed single char contains() 2017-02-13 08:20:45 +00:00
catch_compiler_capabilities.h Update handling of __JETBRAINS_IDE__ macro 2017-09-07 18:00:04 +02:00
catch_config.hpp Implemented wait-for-keypress option 2017-08-15 14:12:11 +01:00
catch_console_colour_impl.hpp Add tests for #835 2017-03-06 22:07:33 +01:00
catch_console_colour.hpp Cleaned up terminal colouring impl and added more config options 2014-10-21 07:24:30 +01:00
catch_context_impl.hpp Clean up generator state 2017-01-16 10:34:16 +00:00
catch_context.h Couple more includes cleaned out 2017-02-12 12:48:25 +01:00
catch_debugger.h Added NOLINT annotations to selectively suppress clang_tidy warnings 2017-07-10 18:43:07 +01:00
catch_debugger.hpp Save errno before using sprintf, ifstream. 2017-03-06 21:51:22 +01:00
catch_default_main.hpp Cosmetic fixes (whitespace and spelling) 2017-05-27 14:42:54 +02:00
catch_errno_guard.hpp Save errno before using sprintf, ifstream. 2017-03-06 21:51:22 +01:00
catch_evaluate.hpp Specialise removeConst for nullptr 2017-08-24 23:07:44 +02:00
catch_exception_translator_registry.hpp exception translators considered even for types deriving from std::exception, now 2015-11-18 08:39:21 +00:00
catch_expression_lhs.hpp Cherry-picked "evaluate" refactoring from dev-modernize branch 2017-08-24 23:07:03 +02:00
catch_fatal_condition.hpp Cosmetic fixes (whitespace and spelling) 2017-05-27 14:42:54 +02:00
catch_generators_impl.hpp Removed all trailing whitespace 2013-07-03 19:14:59 +01:00
catch_generators.hpp Use bulk vector::insert rather than back_inserter 2017-03-15 15:19:38 +00:00
catch_impl.hpp Fixed unintentional tabs 2017-03-06 09:23:31 +00:00
catch_interfaces_capture.h Eliminate some work when results won't be reported. 2017-07-07 01:34:12 +02:00
catch_interfaces_config.h Implemented wait-for-keypress option 2017-08-15 14:12:11 +01:00
catch_interfaces_exception.h Use __COUNTER__ when generating unique names instead of __LINE__, if available. 2016-03-14 07:55:00 +00:00
catch_interfaces_generators.h Removed all trailing whitespace 2013-07-03 19:14:59 +01:00
catch_interfaces_registry_hub.h Tag Alias registry is part of registry hub instead of it’s own singleton 2017-03-15 09:45:37 +00:00
catch_interfaces_reporter.h More include simplifications 2017-02-13 14:12:22 +01:00
catch_interfaces_runner.h Big assertion capture refactoring. 2014-05-28 18:53:01 +01:00
catch_interfaces_tag_alias_registry.h Tag aliases feature 2014-06-30 07:33:17 +01:00
catch_interfaces_testcase.h Stripped trailing whitespace from all source code lines 2015-11-04 18:04:15 +00:00
catch_legacy_reporter_adapter.h Support for reporting skipped tests 2014-12-22 20:10:33 +00:00
catch_legacy_reporter_adapter.hpp Support for reporting skipped tests 2014-12-22 20:10:33 +00:00
catch_list.hpp If --list-extra-info is specified with --list-test-names-only, only output one list 2017-06-25 17:12:29 +02:00
catch_matchers_string.h Take std::string by const-ref where possible 2017-03-06 13:16:43 +01:00
catch_matchers_string.hpp Take std::string by const-ref where possible 2017-03-06 13:16:43 +01:00
catch_matchers_vector.h Added first vector matchers (Contains and Equals) 2017-02-21 16:05:04 +00:00
catch_matchers.hpp Addressed some static analysis warnings 2017-07-19 09:50:08 +02:00
catch_message.h Suppressed a load of warnings 2014-05-19 18:57:14 +01:00
catch_message.hpp Fmt and tag fixup for #876 2017-04-04 11:31:13 +02:00
catch_notimplemented_exception.h Addressed some static analysis warnings 2017-07-19 09:50:08 +02:00
catch_notimplemented_exception.hpp More include simplifications 2017-02-13 14:12:22 +01:00
catch_objc_arc.hpp Conditionally compile clang pragmas 2012-08-16 18:47:41 +01:00
catch_objc.hpp Cosmetic fixes (whitespace and spelling) 2017-05-27 14:42:54 +02:00
catch_option.hpp Cosmetic fixes (whitespace and spelling) 2017-05-27 14:42:54 +02:00
catch_platform.h Merge branch 'windows-header-defines' of https://github.com/horenmar/Catch 2017-01-16 17:00:43 +01:00
catch_ptr.hpp Removed Runner class 2015-07-28 18:55:11 +01:00
catch_reenable_warnings.h Suppress warnings correctly for Intel compiler 2015-03-04 07:54:35 +00:00
catch_registry_hub.hpp Tag Alias registry is part of registry hub instead of it’s own singleton 2017-03-15 09:45:37 +00:00
catch_reporter_registrars.hpp Added CATCH_REGISTER_LISTENER without the INTERNAL_ prefix 2017-03-10 19:15:03 +00:00
catch_reporter_registry.hpp Some small clean-ups and refactorings 2015-09-28 01:09:06 -07:00
catch_result_builder.h Addressed some static analysis warnings 2017-07-19 09:50:08 +02:00
catch_result_builder.hpp Eliminate some work when results won't be reported. 2017-07-07 01:34:12 +02:00
catch_result_type.h Stripped trailing whitespace from all source code lines 2015-11-04 18:04:15 +00:00
catch_run_context.hpp Tweaked how failedButOk assertions are recorded 2017-08-25 11:37:49 +01:00
catch_section_info.h More include simplifications 2017-02-13 14:12:22 +01:00
catch_section_info.hpp More include simplifications 2017-02-13 14:12:22 +01:00
catch_section.h Updated NonCopyable (to include C++11 version) and use for Session and Section 2014-10-03 08:15:27 +01:00
catch_section.hpp Disable deprecation warning of std::uncaught_exception 2017-06-15 11:43:31 +02:00
catch_stream.h Capture std::clog writes and combine them with std::cerr writes (#989) 2017-08-09 15:28:40 +02:00
catch_stream.hpp Capture std::clog writes and combine them with std::cerr writes (#989) 2017-08-09 15:28:40 +02:00
catch_streambuf.h Merge branch 'master' of https://github.com/gnzlbg/Catch 2014-04-18 08:49:35 +01:00
catch_suppress_warnings.h Give up on _Pragma for gcc, force disable Wparentheses in all TUs 2017-04-05 21:37:27 +02:00
catch_tag_alias_registry.h Tag Alias registry is part of registry hub instead of it’s own singleton 2017-03-15 09:45:37 +00:00
catch_tag_alias_registry.hpp Throw instead of calling exit in RegistrarForTagAliases constructor 2017-03-22 18:40:07 +01:00
catch_tag_alias.h Take std::string by const-ref where possible 2017-03-06 13:16:43 +01:00
catch_test_case_info.h Added [!nonportable] tag 2017-01-23 17:44:55 +00:00
catch_test_case_info.hpp Throw instead of calling exit in enforceNotReservedTag 2017-03-22 17:53:22 +01:00
catch_test_case_registry_impl.hpp RandomNumberGenerator::result_type should be unsigned (#1050) 2017-10-15 18:30:40 +02:00
catch_test_case_tracker.hpp Suppress -Wexit-time-destructors in Catch code 2017-03-29 20:30:59 +02:00
catch_test_registry.hpp Added NOLINT annotations to selectively suppress clang_tidy warnings 2017-07-10 18:43:07 +01:00
catch_test_spec_parser.hpp Address some of the Resharper finds for Catch 1 2017-07-31 12:31:45 +02:00
catch_test_spec.hpp Added braces to emphasise the return logic 2016-09-27 09:58:12 +01:00
catch_text.h New version of Clara 2014-03-17 18:40:58 +00:00
catch_timer.h Don’t unconditionally #include <stdint.h> (as earlier MSVC don’t have it) 2017-04-25 08:43:14 +01:00
catch_timer.hpp Removed errant uses of uint64_t 2017-04-25 14:15:59 +00:00
catch_tostring.h Addressed some static analysis warnings 2017-07-19 09:50:08 +02:00
catch_tostring.hpp Fix Catch::toString() linker error when main() is compiled as C++ 2017-03-14 11:54:14 -07:00
catch_totals.hpp Fixed up xml reporter and rebased 2014-12-30 18:24:31 +00:00
catch_type_traits.hpp Cosmetic fixes (whitespace and spelling) 2017-05-27 14:42:54 +02:00
catch_version.h Version struct now uses char* for holding branch name 2017-03-22 17:45:36 +01:00
catch_version.hpp v1.10.0 2017-08-26 15:34:18 +02:00
catch_wildcard_pattern.hpp Moved some std includes out from catch_common.h 2017-02-12 12:17:07 +01:00
catch_windows_h_proxy.h Extracted NOMINMAX and WIN32_LEAN_AND_MEAN guards into a proxy header 2017-01-16 16:52:44 +01:00
catch_xmlwriter.hpp Don't include warning headers from catch_xmlwriter.hpp 2017-06-02 19:10:57 +02:00