Tiago Macarios 0b993d7436 Fix catch exception by reference ... When compiling our codebase with clang we were getting the following error: GSL/tests/algorithm_tests.cpp:198:58: warning: catch handler catches by value; should catch by reference instead [misc-throw-by-value-catch-by-reference] CHECK_THROWS_AS(copy(src_span_dyn, dst_span_static), fail_fast); ^ Looking at the catch source code exceptions were being caught by value. One could have it designed so that users might say: CHECK_THROWS_AS(copy(src_span_dyn, dst_span_static), fail_fast&); But I don't think this is the intent and looking at the Catch tests itself looks like this macro does not expect the reference: REQUIRE_THROWS_AS( thisThrows(), std::domain_error ); CHECK_THROWS_AS( thisDoesntThrow(), std::domain_error ); This commit makes Catch catch exceptions by reference instead of by value.		2017-10-24 20:58:23 -07:00
..
Benchmark	Added benchmark for the char literals change	2017-01-29 23:23:33 +01:00
SelfTest	Fix catch exception by reference	2017-10-24 20:58:23 -07:00
Where did the projects go.txt	Renamed missing project explainer filename	2017-01-09 21:59:53 +00:00