mirror of https://github.com/catchorg/Catch2.git
fe483c056d
This is done by no longer requiring all assertions to be seen
by the JUnit reporter. Since the JUnit reporter never outputs
all assertions, even with `-s`, the only difference from storing
passing assertions in the `CumulativeReporterBase` was some
bookkeeping in deciding which sections are relevant to the output.
Given `TEST_CASE` that just runs many passing assertions, e.g.
```
TEST_CASE( "PERFORMANCE_TEST_CASE", "[.]" ) {
for (size_t i = 0; i < 1000'000'000; ++i) {
REQUIRE( i == i );
}
}
```
the new JUnit reporter will finish in 5:47, using up ~7.7 MB of RAM.
The old JUnit reporter would finish in 0:30, due to bad_alloc
after using up 14.5 GB of RAM (the system has 16 GB total).
If the total number of assertions is lowered to 10M, the old
implementation uses up ~7.1 GB of RAM and finishes in 12 minutes.
The new implementation still needs only ~7.7 MB of RAM, and finishes
in 4 minutes.
There is a slight downside in that the output is slightly different;
the new implementation will include the `TEST_CASE` level section
in output, even if it does not have its own assertion. In other words,
given a `TEST_CASE` like this
```
TEST_CASE( "JsonWriter", "[JSON][JsonWriter]" ) {
std::stringstream stream;
SECTION( "Newly constructed JsonWriter does nothing" ) {
Catch::JsonValueWriter writer{ stream };
REQUIRE( stream.str() == "" );
}
SECTION( "Calling writeObject will create an empty pair of braces" ) {
{ auto writer = Catch::JsonValueWriter{ stream }.writeObject(); }
REQUIRE( stream.str() == "{\n}" );
}
}
```
the new implementation will output 3 `testcase` tags, 2 for the explicit
`SECTION`s with tests, and 1 for the top level section.
However, this can be worked-around if required, and the performance
improvement is such that it is worth changing the current output,
even if it needs to be fixed in the future.
Closes #2897
|
||
|---|---|---|
| .. | ||
| automake.std.approved.txt | ||
| automake.sw.approved.txt | ||
| automake.sw.multi.approved.txt | ||
| compact.sw.approved.txt | ||
| compact.sw.multi.approved.txt | ||
| console.std.approved.txt | ||
| console.sw.approved.txt | ||
| console.sw.multi.approved.txt | ||
| console.swa4.approved.txt | ||
| default.sw.multi.approved.txt | ||
| junit.sw.approved.txt | ||
| junit.sw.multi.approved.txt | ||
| sonarqube.sw.approved.txt | ||
| sonarqube.sw.multi.approved.txt | ||
| tap.sw.approved.txt | ||
| tap.sw.multi.approved.txt | ||
| teamcity.sw.approved.txt | ||
| teamcity.sw.multi.approved.txt | ||
| xml.sw.approved.txt | ||
| xml.sw.multi.approved.txt | ||