3rd-party/poly2tri
1
0
Fork 0
mirror of https://github.com/jhasse/poly2tri.git synced 2024-11-30 01:03:30 +01:00
Code Issues Projects Releases Wiki Activity

Fix #11 - regression causing crash when abs(p1.y - p2.y) < 1e10 (#12)

Browse Source 
This reverts commit e0ba327ed8.

While the orignal commit silences a compiler warning, it introduces incorrect
behavior in Edge constructor that causes crash later during triangulation.

See #11 for an example of a simple polygon that would cause crash
This commit is contained in:
Martin Dobias 2020-01-20 10:19:20 +01:00 committed by Jan Niklas Hasse
parent e6e63dd29e
commit e66d045060
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
poly2tri/common/shapes.h
View File

@ -132,11 +132,11 @@ struct Edge {
if (p1.y > p2.y) { if (p1.y > p2.y) {
q = &p1; q = &p1;
p = &p2; p = &p2;
} else if (std::abs(p1.y - p2.y) < 1e-10) { } else if (p1.y == p2.y) {
if (p1.x > p2.x) { if (p1.x > p2.x) {
q = &p1; q = &p1;
p = &p2; p = &p2;
} else if (std::abs(p1.x - p2.x) < 1e-10) { } else if (p1.x == p2.x) {
// Repeat points // Repeat points
throw std::runtime_error("Edge::Edge: p1 == p2"); throw std::runtime_error("Edge::Edge: p1 == p2");
} }