mhu/gds-render
1
0
Fork 0
Code Issues 4 Pull Requests Releases 8 Wiki Activity

Improve performance by prepending to list inststead of appending. O(n^2) -> O(1)

Browse Source
This commit is contained in:
Mario Hüttel 2019-09-15 13:26:44 +02:00
parent bd97ccf44f
commit cfc156c1c0
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
gds-utils/gds-parser.c
View File

@ -283,13 +283,13 @@ static GList *append_library(GList *curr_list, struct gds_library **library_ptr)
} }
/** /**
* @brief Append graphics to list * @brief Prepend graphics to list
* @param curr_list List containing gds_graphics elements. May be NULL * @param curr_list List containing gds_graphics elements. May be NULL
* @param type Type of graphics * @param type Type of graphics
* @param graphics_ptr newly created graphic is written here * @param graphics_ptr newly created graphic is written here
* @return new list pointer * @return new list pointer
*/ */
static GList *append_graphics(GList *curr_list, enum graphics_type type, static __attribute__((warn_unused_result)) GList *prepend_graphics(GList *curr_list, enum graphics_type type,
struct gds_graphics **graphics_ptr) struct gds_graphics **graphics_ptr)
{ {
struct gds_graphics *gfx; struct gds_graphics *gfx;
@ -308,7 +308,7 @@ static GList *append_graphics(GList *curr_list, enum graphics_type type,
if (graphics_ptr) if (graphics_ptr)
*graphics_ptr = gfx; *graphics_ptr = gfx;
return g_list_append(curr_list, gfx); return g_list_prepend(curr_list, gfx);
} }
/** /**
@ -759,8 +759,10 @@ int parse_gds_from_file(const char *filename, GList **library_list)
run = -3; run = -3;
break; break;
} }
current_cell->graphic_objs = append_graphics(current_cell->graphic_objs, current_cell->graphic_objs = prepend_graphics(current_cell->graphic_objs,
(rec_type == BOUNDARY ? GRAPHIC_POLYGON : GRAPHIC_BOX), (rec_type == BOUNDARY
? GRAPHIC_POLYGON
: GRAPHIC_BOX),
&current_graphics); &current_graphics);
if (current_cell->graphic_objs == NULL) { if (current_cell->graphic_objs == NULL) {
GDS_ERROR("Memory allocation failed"); GDS_ERROR("Memory allocation failed");
@ -791,7 +793,7 @@ int parse_gds_from_file(const char *filename, GList **library_list)
run = -3; run = -3;
break; break;
} }
current_cell->graphic_objs = append_graphics(current_cell->graphic_objs, current_cell->graphic_objs = prepend_graphics(current_cell->graphic_objs,
GRAPHIC_PATH, &current_graphics); GRAPHIC_PATH, &current_graphics);
if (current_cell->graphic_objs == NULL) { if (current_cell->graphic_objs == NULL) {
GDS_ERROR("Memory allocation failed"); GDS_ERROR("Memory allocation failed");